Macro defining macro working with compiler but not `icyc`

[ChillPC]

On cyclone 0.36.0, with the code:

;; main.scm
(import
  (scheme base)
  (scheme write))

(define-syntax
  m
  (syntax-rules ()
    ((_ macro-from who)
     (define-syntax
       macro-from
       (syntax-rules ()
         ((_ from)
          (begin
            (display
              (string-append "Hello " who " from " from "!"))
            (newline))))))))


(m message-for-you "you")

(message-for-you "me")

Compiling:

$ cyclone main.scm && ./main.scm
Hello you from me!

With icyc:

$ icyc -s main.scm
Error: Too few arguments supplied: (expr$52$63$72 rename$53$64$73 compare$54$65$74) ("me") 
Call history, most recent first:
[1] scheme/base.sld:raise
[2] scheme/base.sld:error
[3] scheme/cyclone/util.sld:env:extend-environment
[4] scheme/cyclone/util.sld:pack-lambda-arguments
[5] scheme/cyclone/util.sld:formals->list
[6] scheme/cyclone/util.sld:tagged-list?
[7] scheme/eval.sld:execute-application
[8] scheme/base.sld:Cyc-map-loop-1
[9] scheme/cyclone/util.sld:env:_lookup-variable-value

[yorickhardy]

I can confirm this bug, it also affects cyclone eval.

I need to look more into this, but if I recall correctly this is due to the two "layers" of evaluation and how the evaluation signals that a macro has been defined. In this case the nested macro implementation is taken to be a procedure instead of a macro, i.e. the signalling that it is a macro is lost, whereas the define-syntax at top level correctly identifies the procedure as a macro.

[yorickhardy]

I had a go at fixing this, it is just a hack for now (the "fix" works around how nested define-syntax is evaluated) -- so I don't think it is ready for a pull request yet. But maybe it can provide a starting point for a proper fix?