This repository was archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
ssc init should default to port 1433 #145
Copy link
Copy link
Open
Description
Describe the Feature
When running ssc init currently the default value for port is undefined, this causes the field to be NaN on display and Null on creation.
As i understand it, it would be a more pleasant UX to default to port 1433, which is the usual sql server default port.
Todo
Suggested Solution
The suggested solution is to on line 62 of the init.ts command file switch to 1433 the default value:
sql-source-control/src/commands/init.ts
Lines 62 to 66 in e487dfe
| default: conn.port || undefined, | |
| message: 'Server port.', | |
| name: 'port', | |
| type: 'number', | |
| when: (answers) => answers.path !== PathChoices.WebConfig, |
Other Information
I can make the PR, but i wanted to discuss it first, in case there's some scenarios i am not considering.
Metadata
Metadata
Assignees
Labels
No labels

