Replies: 2 comments
-
@platinops could you please comment on #493 and be more specific on how we could apply black e.g by supplying a pull request. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Okey, done: #499 After this PR is merged, I can do another one for the inconsistent use of spaces, commas and capitals - if that's OK with you. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I'm happy to see that justpy is again being actively developed.
I did note however that several commits to not adhere to PEP8. Some examples:
getServer
->get_server
(incorrect use of CamelCase, src, pep)
self.sleepTime=sleepTime
->self.sleep_time = sleepTime
(incorrect use of spaces around equal sign, src, pep)
global jp_server,func_to_run, startup_func, HOST, PORT
->global jp_server, func_to_run, startup_func, HOST, PORT
(missing space after comma, src, pep)
Would suggest the use of the black package to ascertain consistent code amongst all developers, in line with PEP8, while also appllying PEP8 more correctly w.r.t. CamelCase for classes, but lower_case for functions and variables.
Beta Was this translation helpful? Give feedback.
All reactions