Remove wildcard routes #530
WolfgangFahl
started this conversation in
Ideas
Replies: 2 comments
-
There could be an issue with path parameters if we do this: |
Beta Was this translation helpful? Give feedback.
0 replies
-
Is this still an issue? Isn't this solved now that the code is hooks into starlette routing? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
The current design of justpy sets two routes with a wildcard path:
The motivation seems to be that any path after http://server:port will lead to serving the justpy homepage.
There might also be usecases where the path is analyzed and used for some purpose.
currently i only see the ajax case:
This defeats the RESTFul routing idea that is implemented in starlette and ASGI frameworks in general. There are also
other followup issues such as returning a webpage instead of creating a 404 result code if the path is not handled correctly.
As part of the refactoring according to #478 and #502 I suggest to change the behavior and not use a wildcard route any more.
Beta Was this translation helpful? Give feedback.
All reactions