Draft - Remove other type #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Remove reference of other_type that were missed in the initial commits.
…into remove_other_type
In progress check to understand in-line allocation of other.
Tweak to see why CI test fails for this.
Test to see if stack size increase addresses CI failure.
Add double hyphen for GCC nomenclature.
Bug fix on linker line
Revert example/CMakesLists.txt back to original.
Bugfix
Test to see if updating to chaining hashmaps fixes the single CI failure.
Update to remove remaining references to the 'other_type' derived type.
Remove reference to other_type
Remove 'other_type' reference.
Remove reference to 'other_type'.
Try allocate(new_ent % other, source = other) one more time.
Another try
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Reverting back to inline allocation based on PR discussion. Both approaches seemed to work fine.
This reverts commit 3c60ba4.
This reverts commit 7118fc5.
Remove outdated comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.