Added Timber library checks (#1)

Author: jvilya

src/main/resources/org/sonar/l10n/androidlint/rules/Android_lint_profile.json

@@ -313,6 +313,14 @@
     "RtlCompat",
     "RtlSymmetry",
     "RtlHardcoded",
-    "RtlEnabled"
+    "RtlEnabled",
+    "LogNotTimber",
+    "StringFormatInTimber",
+    "ThrowableNotAtBeginning",
+    "BinaryOperationInTimber",
+    "TimberArgCount",
+    "TimberArgTypes",
+    "TimberTagLength",
+    "TimberExceptionLogging"
   ]
 }

src/main/resources/org/sonar/l10n/androidlint/rules/BinaryOperationInTimber.html

@@ -0,0 +1,3 @@
+<p>
+Since Timber handles String#format() automatically, use this instead of String concatenation.
+</p>

src/main/resources/org/sonar/l10n/androidlint/rules/BinaryOperationInTimber.json

@@ -0,0 +1,17 @@
+{
+  "sqKey": "BinaryOperationInTimber",
+  "title": "Use String#format()",
+  "type": "CODE_SMELL",
+  "tags": [
+    "android",
+    "timber",
+    "correctness#messages"
+  ],
+  "defaultSeverity": "MINOR",
+  "remediation": {
+    "func": "Constant\\/Issue",
+    "constantCost": "5min"
+  },
+  "status": "ready",
+  "scope": "All"
+}

src/main/resources/org/sonar/l10n/androidlint/rules/LogNotTimber.html

@@ -0,0 +1,3 @@
+<p>
+Since Timber is included in the project, it is likely that calls to Log should instead be going to Timber.
+</p>

src/main/resources/org/sonar/l10n/androidlint/rules/LogNotTimber.json

@@ -0,0 +1,17 @@
+{
+  "sqKey": "LogNotTimber",
+  "title": "Logging call to Log instead of Timber",
+  "type": "CODE_SMELL",
+  "tags": [
+    "android",
+    "timber",
+    "correctness#messages"
+  ],
+  "defaultSeverity": "MINOR",
+  "remediation": {
+    "func": "Constant\\/Issue",
+    "constantCost": "5min"
+  },
+  "status": "ready",
+  "scope": "All"
+}

src/main/resources/org/sonar/l10n/androidlint/rules/StringFormatInTimber.html

@@ -0,0 +1,3 @@
+<p>
+Since Timber handles String.format automatically, you may not use String#format().
+</p>

src/main/resources/org/sonar/l10n/androidlint/rules/StringFormatInTimber.json

@@ -0,0 +1,17 @@
+{
+  "sqKey": "StringFormatInTimber",
+  "title": "Logging call with Timber contains String#format()",
+  "type": "CODE_SMELL",
+  "tags": [
+    "android",
+    "timber",
+    "correctness#messages"
+  ],
+  "defaultSeverity": "MINOR",
+  "remediation": {
+    "func": "Constant\\/Issue",
+    "constantCost": "5min"
+  },
+  "status": "ready",
+  "scope": "All"
+}

src/main/resources/org/sonar/l10n/androidlint/rules/ThrowableNotAtBeginning.html

@@ -0,0 +1,3 @@
+<p>
+In Timber you have to pass a Throwable at the beginning of the call.
+</p>

src/main/resources/org/sonar/l10n/androidlint/rules/ThrowableNotAtBeginning.json

@@ -0,0 +1,17 @@
+{
+  "sqKey": "ThrowableNotAtBeginning",
+  "title": "Exception in Timber not at the beginning",
+  "type": "CODE_SMELL",
+  "tags": [
+    "android",
+    "timber",
+    "correctness#messages"
+  ],
+  "defaultSeverity": "MINOR",
+  "remediation": {
+    "func": "Constant\\/Issue",
+    "constantCost": "5min"
+  },
+  "status": "ready",
+  "scope": "All"
+}

src/main/resources/org/sonar/l10n/androidlint/rules/TimberArgCount.html

@@ -0,0 +1,3 @@
+<p>
+When a formatted string takes arguments, you need to pass at least that amount of arguments to the formatting call.
+</p>