fix: fix logic to check level up

Author: dybyte

src/main/java/com/dinosaur/dinosaurexploder/controller/DinosaurController.java

@@ -250,8 +250,7 @@ public void initPhysics() {
             }
             projectile.removeFromWorld();
             greenDino.removeFromWorld();
-            collisionHandler.onProjectileHitDino(score.getComponent(ScoreComponent.class));
-            if (levelManager.shouldAdvanceLevel()) {
+            if (collisionHandler.isLevelUpAfterHitDino(score.getComponent(ScoreComponent.class))) {
                 showLevelMessage();
                 System.out.println("Level up!");
             }

src/main/java/com/dinosaur/dinosaurexploder/model/CollisionHandler.java

@@ -15,11 +15,11 @@ public CollisionHandler(LevelManager levelManager) {
         this.levelManager = levelManager;
     }
 
-    public void onProjectileHitDino(ScoreComponent scoreComponent) {
+    public boolean isLevelUpAfterHitDino(ScoreComponent scoreComponent) {
         scoreComponent.incrementScore(1);
         levelManager.incrementDefeatedEnemies();
 
-        adjustLevel();
+        return adjustLevel();
     }
 
     public void handleHitBoss(RedDinoComponent redDinoComponent) {
@@ -53,9 +53,11 @@ public void onPlayerGetHeart(LifeComponent lifeComponent) {
         lifeComponent.increaseLife(1);
     }
 
-    private void adjustLevel() {
+    private boolean adjustLevel() {
         if (levelManager.shouldAdvanceLevel()) {
             levelManager.nextLevel();
+            return true;
         }
+        return false;
     }
 }

src/test/java/com/dinosaur/dinosaurexploder/model/CollisionHandlerTest.java

@@ -35,7 +35,7 @@ void setUp() {
     void projectileHitDino_thenLevelUp() {
         ScoreComponent scoreComponent = new ScoreComponent();
 
-        for (int i = 0; i < LEVEL_UP_COUNT; i++) collisionHandler.onProjectileHitDino(scoreComponent);
+        for (int i = 0; i < LEVEL_UP_COUNT; i++) collisionHandler.isLevelUpAfterHitDino(scoreComponent);
 
         assertEquals(2, levelManager.getCurrentLevel());
     }
@@ -44,7 +44,7 @@ void projectileHitDino_thenLevelUp() {
     void projectileHitDino_thenScoreIncrease() {
         ScoreComponent scoreComponent = new ScoreComponent();
 
-        collisionHandler.onProjectileHitDino(scoreComponent);
+        collisionHandler.isLevelUpAfterHitDino(scoreComponent);
 
         assertEquals(1, scoreComponent.getScore());
     }