Added packaging compatibility checks

Author: jwagner

package.json

@@ -14,7 +14,7 @@
     "dist/simplex-noise.js.map",
     "dist/simplex-noise.mjs",
     "dist/simplex-noise.mjs.map",
-    "dist/index.d.ts"
+    "dist/types.d.ts"
   ],
   "devDependencies": {
     "@parcel/packager-ts": "^2.0.0-rc.0",
@@ -58,9 +58,9 @@
   },
   "scripts": {
     "start": "parcel test/visual.html",
-    "test": "eslint simplex-noise.ts && mocha",
+    "test": "eslint simplex-noise.ts && mocha && ./test/module-compatibility.sh",
     "build": "parcel build",
     "prepare": "npm run-script build",
-    "benchmark": "node ./perf/benchmark.js"
+    "benchmark": "parcel build && node ./perf/benchmark.js"
   }
-}
+}

perf/benchmark.js

@@ -1,42 +1,42 @@
-var Benchmark = this.Benchmark || require('benchmark');
-var SimplexNoise = this.SimplexNoise || require('../simplex-noise');
-var simplex = new SimplexNoise();
+const Benchmark = this.Benchmark || require('benchmark');
+const SimplexNoise = this.SimplexNoise || require('..');
+const simplex = new SimplexNoise();
 
-var suite = new Benchmark.Suite('simplex-noise')
+new Benchmark.Suite('simplex-noise')
   .add('init', function() {
-    var simplex = new SimplexNoise();
+    new SimplexNoise();
   })
   .add('noise2D', function() {
-    for (var x = 0; x < 8; x++) {
-      for (var y = 0; y < 8; y++) {
-        for (var z = 0; z < 8; z++) {
+    for (let x = 0; x < 8; x++) {
+      for (let y = 0; y < 8; y++) {
+        for (let z = 0; z < 8; z++) {
           simplex.noise2D(x / 8, y / 8);
         }
       }
     }
   })
   .add('noise3D', function() {
-    for (var x = 0; x < 8; x++) {
-      for (var y = 0; y < 8; y++) {
-        for (var z = 0; z < 8; z++) {
+    for (let x = 0; x < 8; x++) {
+      for (let y = 0; y < 8; y++) {
+        for (let z = 0; z < 8; z++) {
           simplex.noise3D(x / 8, y / 8, z / 8);
         }
       }
     }
   })
   .add('noise3D2', function() {
-    for (var x = 0; x < 8; x++) {
-      for (var y = 0; y < 8; y++) {
-        for (var z = 0; z < 8; z++) {
+    for (let x = 0; x < 8; x++) {
+      for (let y = 0; y < 8; y++) {
+        for (let z = 0; z < 8; z++) {
           simplex.noise3D(x / 8, y / 8, z / 8);
         }
       }
     }
   })
   .add('noise4D', function() {
-    for (var x = 0; x < 8; x++) {
-      for (var y = 0; y < 8; y++) {
-        for (var z = 0; z < 8; z++) {
+    for (let x = 0; x < 8; x++) {
+      for (let y = 0; y < 8; y++) {
+        for (let z = 0; z < 8; z++) {
           simplex.noise4D(x / 8, y / 8, z / 8, (x + y) / 16);
         }
       }

simplex-noise.ts

@@ -464,3 +464,9 @@ function masher() {
     return (n >>> 0) * 2.3283064365386963e-10; // 2^-32
   };
 }
+
+// nasty hack to make the default export stay the same as 2.x
+// when used in commonjs
+if (typeof module !== undefined) {
+  module.exports = SimplexNoise;
+}

test/module-compatibility.sh

@@ -0,0 +1,28 @@
+#!/bin/bash
+NAME=$(jq -r .name package.json)
+set -e
+node_major_version=$(node --version|sed 's/v\([^.]*\).*/\1/g')
+rm -rf e2e
+mkdir -p e2e
+rm -f $($NAME*.tgz)
+npm pack
+tarball=($NAME*.tgz)
+mv "$tarball" e2e
+cd e2e
+cp -R ../test/module-compatibility .
+cd module-compatibility
+npm install "../$tarball" 
+echo "testing node commonjs"
+node commonjs.js
+if [ "$node_major_version" -ge 14 ]
+  then
+  echo "testing typescript"
+  cp esm.mjs typescript.ts
+  node --loader ts-node/esm  typescript.ts
+    echo "testing node esm"
+    node esm.mjs
+fi
+cd ..
+
+cd ..
+rm -rf e2e

test/module-compatibility/commonjs.js

@@ -0,0 +1,3 @@
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const SimplexNoise = require('simplex-noise');
+console.log(new SimplexNoise('seed').noise2D(1, 2));

test/module-compatibility/esm.mjs

@@ -0,0 +1,2 @@
+import SimplexNoise from 'simplex-noise';
+console.log(new SimplexNoise('seed').noise2D(1, 2));

test/module-compatibility/package.json

@@ -0,0 +1 @@
+{}