Skip to content
This repository was archived by the owner on Mar 23, 2024. It is now read-only.

Commit 453089f

Browse files
committed
Change data-main formatting for RequireJS 2.0
Also remove dead _data_main code from earlier merges
1 parent 3de0cb1 commit 453089f

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

app/helpers/requirejs_helper.rb

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def _requirejs_data(name, &block)
1111
{}.tap do |data|
1212
if name
1313
name += ".js" unless name =~ /\.js$/
14-
data['main'] = _javascript_path(name)
14+
data['main'] = _javascript_path(name).sub(/\.js$/,'')
1515
end
1616

1717
data.merge!(yield controller) if block_given?
@@ -20,15 +20,6 @@ def _requirejs_data(name, &block)
2020
end.join(" ")
2121
end
2222

23-
def _data_main(name)
24-
if name
25-
name += ".js" unless name =~ /\.js$/
26-
%Q{data-main="#{_javascript_path(name)}"}
27-
else
28-
""
29-
end
30-
end
31-
3223
def requirejs_include_tag(name=nil, &block)
3324
requirejs = Rails.application.config.requirejs
3425

test/requirejs-rails_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def wrap(tag)
129129

130130
test "requirejs_include_tag_with_param" do
131131
render :text => wrap(requirejs_include_tag("application"))
132-
assert_select "script:last-of-type[src^=/javascripts/require.js][data-main^=/javascripts/application.js]", :count => 1
132+
assert_select "script:last-of-type[src^=/javascripts/require.js][data-main^=/javascripts/application]", :count => 1
133133
end
134134

135135
test "requirejs_include_tag_with_block" do
@@ -138,7 +138,7 @@ def wrap(tag)
138138
end
139139

140140
render :text => wrap(requirejs_include_tag("application", &test_block))
141-
assert_select "script:last-of-type[src^=/javascripts/require.js][data-main^=/javascripts/application.js]", :count => 1
141+
assert_select "script:last-of-type[src^=/javascripts/require.js][data-main^=/javascripts/application]", :count => 1
142142
assert_select "script:last-of-type[src^=/javascripts/require.js][data-class^=TestController]", :count => 1
143143
end
144144

0 commit comments

Comments
 (0)