Skip to content

Commit 28f527d

Browse files
committed
fix: Make error handling explicit in CI debug steps
Replace silent error swallowing (|| true) with explicit messages explaining why commands might fail in debug output. This addresses code review feedback from @cgwalters about making CI error handling more transparent. Addresses: ambient-code#367 (review)
1 parent 239284a commit 28f527d

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

.github/workflows/test-local-dev.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -103,47 +103,47 @@ jobs:
103103
if: always()
104104
run: |
105105
echo "=== Namespace ==="
106-
kubectl get namespace ambient-code || true
106+
kubectl get namespace ambient-code 2>&1 || echo "(Namespace not found - may not have been created)"
107107
108108
echo ""
109109
echo "=== Deployments ==="
110-
kubectl get deployments -n ambient-code -o wide || true
110+
kubectl get deployments -n ambient-code -o wide 2>&1 || echo "(No deployments found or namespace does not exist)"
111111
112112
echo ""
113113
echo "=== ReplicaSets ==="
114-
kubectl get replicasets -n ambient-code -o wide || true
114+
kubectl get replicasets -n ambient-code -o wide 2>&1 || echo "(No replicasets found or namespace does not exist)"
115115
116116
echo ""
117117
echo "=== Pods ==="
118-
kubectl get pods -n ambient-code -o wide || true
118+
kubectl get pods -n ambient-code -o wide 2>&1 || echo "(No pods found or namespace does not exist)"
119119
120120
echo ""
121121
echo "=== Services ==="
122-
kubectl get svc -n ambient-code || true
122+
kubectl get svc -n ambient-code 2>&1 || echo "(No services found or namespace does not exist)"
123123
124124
echo ""
125125
echo "=== Ingress ==="
126-
kubectl get ingress -n ambient-code || true
126+
kubectl get ingress -n ambient-code 2>&1 || echo "(No ingress found or namespace does not exist)"
127127
128128
echo ""
129129
echo "=== CRDs ==="
130-
kubectl get crd | grep vteam || true
130+
kubectl get crd 2>&1 | grep vteam || echo "(No vteam CRDs found)"
131131
132132
echo ""
133133
echo "=== Events (last 30) ==="
134-
kubectl get events -n ambient-code --sort-by='.lastTimestamp' | tail -30 || true
134+
kubectl get events -n ambient-code --sort-by='.lastTimestamp' 2>&1 | tail -30 || echo "(No events found or namespace does not exist)"
135135
136136
echo ""
137137
echo "=== Deployment describe (if no pods) ==="
138138
if ! kubectl get pods -n ambient-code 2>/dev/null | grep -q "backend-api\|frontend\|agentic-operator"; then
139139
echo "No pods found - describing deployments for details:"
140-
kubectl describe deployment backend-api -n ambient-code 2>/dev/null | tail -50 || true
141-
kubectl describe deployment frontend -n ambient-code 2>/dev/null | tail -50 || true
142-
kubectl describe deployment agentic-operator -n ambient-code 2>/dev/null | tail -50 || true
140+
kubectl describe deployment backend-api -n ambient-code 2>&1 | tail -50 || echo "(backend-api deployment not found)"
141+
kubectl describe deployment frontend -n ambient-code 2>&1 | tail -50 || echo "(frontend deployment not found)"
142+
kubectl describe deployment agentic-operator -n ambient-code 2>&1 | tail -50 || echo "(agentic-operator deployment not found)"
143143
fi
144144
145145
- name: Cleanup
146146
if: always()
147147
run: |
148148
echo "Cleaning up using Makefile..."
149-
make local-clean || true
149+
make local-clean 2>&1 || echo "(Cleanup failed or cluster already removed)"

0 commit comments

Comments
 (0)