Skip to content

Commit b27eb19

Browse files
committed
update aws snippets based on feedback
1 parent 11b7b10 commit b27eb19

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

snippets/functions/third-party/awsKinesis.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ exports = async function () {
1111
region: "us-east-1",
1212
maxAttempts: 5,
1313
});
14-
const params = {
15-
StreamName: "myStreamName",
16-
};
1714

1815
// see https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/kinesis/ for more commands
19-
const describeStreamCommand = new DescribeStreamCommand(params);
16+
const describeStreamCommand = new DescribeStreamCommand({
17+
StreamName: "myStreamName",
18+
});
19+
2020
try {
2121
const data = await kinesisClient.send(describeStreamCommand);
2222
return data.StreamDescription.StreamName;

snippets/functions/third-party/awsS3PutObject.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ exports = async function () {
2020
});
2121
try {
2222
const data = await s3Client.send(putObjectCommand);
23-
return data !== null && data.ETag !== "";
23+
return data;
2424
} catch (error) {
2525
return error;
2626
}

snippets/functions/third-party/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"id": "fdf44706-adbe-4880-87b5-e9c28f6110ab",
4444
"title": "Putting object in AWS S3 bucket",
4545
"snippet": "/awsS3PutObject.js",
46-
"description": "Putting an object into AWS S3 bucket with the bucket name and key. To authenticate with the AWS client, store your AccessKeyID and SecretAccessKey as values. Note: This is using AWS SDK v3."
46+
"description": "Uploads an object to an AWS S3 bucket using the specified bucket name and key. Authentication requires your AWS AccessKeyID, SecretAccessKey and BucketKey, all of which should be stored as values. This operation uses AWS SDK v3."
4747
}
4848
]
4949
}

0 commit comments

Comments
 (0)