Skip to content

Commit 8417a59

Browse files
committed
fix: install xml2 for coverage workflow
1 parent 00b32ea commit 8417a59

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

.github/workflows/test-coverage.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ jobs:
2424

2525
- uses: r-lib/actions/setup-r-dependencies@v2
2626
with:
27-
extra-packages: any::covr
27+
extra-packages: |
28+
any::covr
29+
any::xml2
2830
needs: coverage
2931

3032
- name: Test coverage

DESCRIPTION

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,15 @@ URL: https://jwood000.github.io/RcppAlgos/,
3030
BugReports: https://github.com/jwood000/RcppAlgos/issues
3131
LinkingTo: cpp11
3232
Imports: gmp, methods
33-
Suggests: testthat, partitions, microbenchmark, knitr, RcppBigIntAlgos, rmarkdown
33+
Suggests:
34+
testthat,
35+
partitions,
36+
microbenchmark,
37+
knitr,
38+
RcppBigIntAlgos,
39+
rmarkdown,
40+
covr,
41+
xml2
3442
Config/Needs/website: pkgdown
3543
License: GPL (>=2)
3644
SystemRequirements: gmp (>= 4.2.3)

src/ExposeClass.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
static void Finalizer(SEXP ext) {
1212
if (TYPEOF(ext) != EXTPTRSXP) return;
1313

14-
auto* ptr =
15-
reinterpret_cast<Iterator*>(R_ExternalPtrAddr(ext));
16-
14+
auto* ptr = reinterpret_cast<Iterator*>(R_ExternalPtrAddr(ext));
1715
if (!ptr) return;
1816

1917
R_ClearExternalPtr(ext);

0 commit comments

Comments
 (0)