Skip to content

Commit 0fdf15c

Browse files
authored
[CQ] remove (dead) FlutterStudioInitializer (flutter#8212)
`FlutterStudioInitializer` exists to perform a check at startup to ensure AS is current enough for... something... I can't recall the motivation for this extra check (despite having reviewed it in flutter#1346 😬) but it was **8 years ago**! Needless to say, removing it is surely safe: 1. the `com.intellij.androidStudioInitializer` extension point seems to have gone away, and even if it hadn't, 2. we're surely past the window where there are any version out there that are too early for the version check --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](flutter#8098)). </details>
1 parent 546022d commit 0fdf15c

File tree

3 files changed

+0
-30
lines changed

3 files changed

+0
-30
lines changed

flutter-studio/src/io/flutter/FlutterStudioInitializer.java

Lines changed: 0 additions & 28 deletions
This file was deleted.

resources/META-INF/studio-contribs.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
<extensions defaultExtensionNs="com.intellij">
1212
<externalSystemTaskNotificationListener implementation="io.flutter.utils.FlutterExternalSystemTaskNotificationListener"/>
13-
<androidStudioInitializer implementation="io.flutter.FlutterStudioInitializer"/>
1413
<postStartupActivity implementation="io.flutter.FlutterStudioStartupActivity"/>
1514
<projectOpenProcessor implementation="io.flutter.editor.FlutterStudioProjectOpenProcessor" order="after flutter"/>
1615
<library.type implementation="io.flutter.android.AndroidModuleLibraryType"/>

resources/META-INF/studio-contribs_template.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
<extensions defaultExtensionNs="com.intellij">
1010
<externalSystemTaskNotificationListener implementation="io.flutter.utils.FlutterExternalSystemTaskNotificationListener"/>
11-
<androidStudioInitializer implementation="io.flutter.FlutterStudioInitializer"/>
1211
<postStartupActivity implementation="io.flutter.FlutterStudioStartupActivity"/>
1312
<projectOpenProcessor implementation="io.flutter.editor.FlutterStudioProjectOpenProcessor" order="after flutter"/>
1413
<library.type implementation="io.flutter.android.AndroidModuleLibraryType"/>

0 commit comments

Comments
 (0)