Skip to content

Commit 3fc0323

Browse files
leevh0908sobychacko
authored andcommitted
Milvus vector store: Pass databaseName in DeleteParam for non-default databases
When using a non-default database, MilvusVectorStore's doDelete method wasn't passing the specified databaseName in DeleteParam, causing searches to fall back to the default database where collections couldn't be found. Added explicit databaseName parameter to fix this issue. - Add databaseName to DeleteParam builder - Upgrade milvus-sdk from 2.3.4 to 2.3.5
1 parent cf17a6d commit 3fc0323

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
<oracle.version>23.4.0.24.05</oracle.version>
201201
<postgresql.version>42.7.2</postgresql.version>
202202
<elasticsearch-java.version>8.13.3</elasticsearch-java.version>
203-
<milvus.version>2.3.4</milvus.version>
203+
<milvus.version>2.3.5</milvus.version>
204204
<gemfire.testcontainers.version>2.3.0</gemfire.testcontainers.version>
205205
<pinecone.version>0.8.0</pinecone.version>
206206
<fastjson.version>2.0.46</fastjson.version>

vector-stores/spring-ai-milvus-store/src/main/java/org/springframework/ai/vectorstore/MilvusVectorStore.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ public Optional<Boolean> doDelete(List<String> idList) {
197197
idList.stream().map(id -> "'" + id + "'").collect(Collectors.joining(",")));
198198

199199
R<MutationResult> status = this.milvusClient.delete(DeleteParam.newBuilder()
200+
.withDatabaseName(this.config.databaseName)
200201
.withCollectionName(this.config.collectionName)
201202
.withExpr(deleteExpression)
202203
.build());

0 commit comments

Comments
 (0)