fix: patching the local server options (disabledRuleIds, blockedReferrers, pipelineCaching, premiumOnly and pipelinePrewarming wasn't working) and removing deprecated options

Author: mdevolde

language_tool_python/config_file.py

@@ -5,12 +5,12 @@
 import tempfile
 
 ALLOWED_CONFIG_KEYS = { 
-    'maxTextLength', 'maxTextHardLength', 'secretTokenKey', 'maxCheckTimeMillis', 'maxErrorsPerWordRate',
-    'maxSpellingSuggestions', 'maxCheckThreads', 'cacheSize', 'cacheTTLSeconds', 'cacheSize', 'requestLimit',
+    'maxTextLength', 'maxTextHardLength', 'maxCheckTimeMillis', 'maxErrorsPerWordRate',
+    'maxSpellingSuggestions', 'maxCheckThreads', 'cacheSize', 'cacheTTLSeconds', 'requestLimit',
     'requestLimitInBytes', 'timeoutRequestLimit', 'requestLimitPeriodInSeconds', 'languageModel',
-    'word2vecModel', 'fasttextModel', 'fasttextBinary', 'maxWorkQueueSize', 'rulesFile', 'warmUp',
+    'fasttextModel', 'fasttextBinary', 'maxWorkQueueSize', 'rulesFile',
     'blockedReferrers', 'premiumOnly', 'disabledRuleIds', 'pipelineCaching', 'maxPipelinePoolSize',
-    'pipelineCaching', 'pipelineExpireTimeInSeconds', 'pipelinePrewarming'
+    'pipelineExpireTimeInSeconds', 'pipelinePrewarming'
 }
 class LanguageToolConfig:
     config: Dict[str, Any]
@@ -19,6 +19,15 @@ def __init__(self, config: Dict[str, Any]):
         assert set(config.keys()) <= ALLOWED_CONFIG_KEYS, f"unexpected keys in config: {set(config.keys()) - ALLOWED_CONFIG_KEYS}"
         assert len(config), "config cannot be empty"
         self.config = config
+
+        if 'disabledRuleIds' in self.config:
+            self.config['disabledRuleIds'] = ','.join(self.config['disabledRuleIds'])
+        if 'blockedReferrers' in self.config:
+            self.config['blockedReferrers'] = ','.join(self.config['blockedReferrers'])
+        for key in ["pipelineCaching", "premiumOnly", "pipelinePrewarming"]:
+            if key in self.config:
+                self.config[key] = str(bool(self.config[key])).lower()
+
         self.path = self._create_temp_file()
 
     def _create_temp_file(self) -> str:

tests/test_major_functionality.py

@@ -255,6 +255,17 @@ def test_session_only_new_spellings():
     assert initial_checksum.hexdigest() == subsequent_checksum.hexdigest()
 
 
+def test_disabled_rule_in_config():
+    import language_tool_python
+    GRAMMAR_TOOL_CONFIG = {
+        'disabledRuleIds': ['MORFOLOGIK_RULE_EN_US']
+    }
+    with language_tool_python.LanguageTool('en-US', config=GRAMMAR_TOOL_CONFIG) as tool:
+        text = "He realised that the organization was in jeopardy."
+        matches = tool.check(text)
+        assert len(matches) == 0
+
+
 def test_debug_mode():
     from language_tool_python.server import DEBUG_MODE
     assert DEBUG_MODE is False