Merge pull request projectdiscovery#6944 from maxwolf8852/fix/noHostErrors-panic

fix: remove nil interface set in createEphemeralObjects to avoid panic

Author: Mzack9999

lib/multi.go

@@ -29,18 +29,17 @@ type unsafeOptions struct {
 func createEphemeralObjects(ctx context.Context, base *NucleiEngine, opts *types.Options) (*unsafeOptions, error) {
 	u := &unsafeOptions{}
 	u.executerOpts = &protocols.ExecutorOptions{
-		Output:          base.customWriter,
-		Options:         opts,
-		Progress:        base.customProgress,
-		Catalog:         base.catalog,
-		IssuesClient:    base.rc,
-		RateLimiter:     base.rateLimiter,
-		Interactsh:      base.interactshClient,
-		HostErrorsCache: base.hostErrCache,
-		Colorizer:       aurora.NewAurora(true),
-		ResumeCfg:       types.NewResumeCfg(),
-		Parser:          base.parser,
-		Browser:         base.browserInstance,
+		Output:       base.customWriter,
+		Options:      opts,
+		Progress:     base.customProgress,
+		Catalog:      base.catalog,
+		IssuesClient: base.rc,
+		RateLimiter:  base.rateLimiter,
+		Interactsh:   base.interactshClient,
+		Colorizer:    aurora.NewAurora(true),
+		ResumeCfg:    types.NewResumeCfg(),
+		Parser:       base.parser,
+		Browser:      base.browserInstance,
 	}
 	if opts.ShouldUseHostError() && base.hostErrCache != nil {
 		u.executerOpts.HostErrorsCache = base.hostErrCache

lib/sdk_test.go

@@ -3,10 +3,12 @@ package nuclei_test
 import (
 	"context"
 	"log"
+	"os"
 	"testing"
 	"time"
 
 	nuclei "github.com/projectdiscovery/nuclei/v3/lib"
+	"github.com/projectdiscovery/nuclei/v3/pkg/types"
 	"github.com/stretchr/testify/require"
 )
 
@@ -55,3 +57,49 @@ func TestHeadlessOptionInitialization(t *testing.T) {
 
 	defer ne.Close()
 }
+
+func TestThreadSafeNucleiEngineWithNoHostErrors(t *testing.T) {
+	tmpDir, err := os.MkdirTemp("", "nuclei-test-no-host-errors-*")
+	require.NoError(t, err)
+
+	tempTemplate, err := os.CreateTemp(tmpDir, "thread-safe-no-host-errors.*.yaml")
+	require.NoError(t, err)
+
+	_, err = tempTemplate.WriteString(`id: thread-safe-no-host-errors
+info:
+  name: Thread Safe (NoHostErrors)
+  author: nuclei-sdk-test
+  severity: info
+http:
+  - method: GET
+    path:
+      - "{{BaseURL}}/"
+    matchers:
+      - type: word
+        words:
+          - "ok"`)
+	require.NoError(t, err)
+	require.NoError(t, tempTemplate.Close())
+
+	options := types.DefaultOptions().Copy()
+	options.NoHostErrors = true
+	options.Timeout = 2
+	options.Retries = 0
+	options.BulkSize = 1
+	options.TemplateThreads = 1
+	options.Templates = append(options.Templates, tempTemplate.Name())
+
+	ne, err := nuclei.NewThreadSafeNucleiEngineCtx(context.TODO(), nuclei.WithOptions(options))
+	require.NoError(t, err, "could not create nuclei engine")
+
+	defer func() {
+		ne.Close()
+		_ = os.RemoveAll(tmpDir)
+	}()
+
+	err = ne.GlobalLoadAllTemplates()
+	require.NoError(t, err, "could not load templates")
+
+	err = ne.ExecuteNucleiWithOptsCtx(context.TODO(), []string{"scanme.sh"})
+	require.NoError(t, err, "nuclei execution should not return an error")
+}