Add Support for FlatcarContainerLinux (#221)

* Provide string constant functions through dedicated interface

Using a dedicated interface enables distro-specific structs to 'override'
functions returning string constants such as config folders or paths.

* Create path for k0s binary if it does not already exists

* Add support for FlatcarContainerLinux

* Rename struct holding path functions for linux

* Add test for linux path functions

Co-authored-by: Kimmo Lehto <[email protected]>

Author: bephinix

configurer/linux.go

@@ -2,6 +2,7 @@ package configurer
 
 import (
 	"fmt"
+	"path"
 	"regexp"
 	"strconv"
 	"strings"
@@ -10,8 +11,18 @@ import (
 	"github.com/k0sproject/rig/os"
 )
 
+// Static Constants Interface for overriding by distro-specific structs
+type PathFuncs interface {
+	K0sBinaryPath() string
+	K0sConfigPath() string
+	K0sJoinTokenPath() string
+	KubeconfigPath() string
+}
+
 // Linux is a base module for various linux OS support packages
-type Linux struct{}
+type Linux struct {
+	PathFuncs
+}
 
 // NOTE The Linux struct does not embed rig/os.Linux because it will confuse
 // go as the distro-configurers' parents embed it too. This means you can't
@@ -46,7 +57,7 @@ func (l Linux) Chmod(h os.Host, path, chmod string) error {
 
 // K0sCmdf can be used to construct k0s commands in sprintf style.
 func (l Linux) K0sCmdf(template string, args ...interface{}) string {
-	return fmt.Sprintf("%s %s", l.K0sBinaryPath(), fmt.Sprintf(template, args...))
+	return fmt.Sprintf("%s %s", l.PathFuncs.K0sBinaryPath(), fmt.Sprintf(template, args...))
 }
 
 // K0sBinaryPath returns the location of k0s binary
@@ -87,12 +98,16 @@ func (l Linux) DownloadK0s(h os.Host, version, arch string) error {
 		return err
 	}
 
-	return h.Execf(`install -m 0750 -o root -g adm "%s" "%s"`, tmp, l.K0sBinaryPath(), exec.Sudo(h))
+	if err := h.Execf(`install -m 0755 -o root -g root -d "%s"`, path.Dir(l.PathFuncs.K0sBinaryPath()), exec.Sudo(h)); err != nil {
+		return err
+	}
+
+	return h.Execf(`install -m 0750 -o root -g adm "%s" "%s"`, tmp, l.PathFuncs.K0sBinaryPath(), exec.Sudo(h))
 }
 
 // ReplaceK0sTokenPath replaces the config path in the service stub
 func (l Linux) ReplaceK0sTokenPath(h os.Host, spath string) error {
-	return h.Exec(fmt.Sprintf("sed -i 's^REPLACEME^%s^g' %s", l.K0sJoinTokenPath(), spath))
+	return h.Exec(fmt.Sprintf("sed -i 's^REPLACEME^%s^g' %s", l.PathFuncs.K0sJoinTokenPath(), spath))
 }
 
 // FileContains returns true if a file contains the substring
@@ -117,7 +132,7 @@ func (l Linux) KubeconfigPath() string {
 
 // KubectlCmdf returns a command line in sprintf manner for running kubectl on the host using the kubeconfig from KubeconfigPath
 func (l Linux) KubectlCmdf(s string, args ...interface{}) string {
-	return l.K0sCmdf(`kubectl --kubeconfig "%s" %s`, l.KubeconfigPath(), fmt.Sprintf(s, args...))
+	return l.K0sCmdf(`kubectl --kubeconfig "%s" %s`, l.PathFuncs.KubeconfigPath(), fmt.Sprintf(s, args...))
 }
 
 // HTTPStatus makes a HTTP GET request to the url and returns the status code or an error

configurer/linux/alpine.go

@@ -27,7 +27,9 @@ func init() {
 			return os.ID == "alpine"
 		},
 		func() interface{} {
-			return Alpine{}
+			linuxType := &Alpine{}
+			linuxType.PathFuncs = interface{}(linuxType).(configurer.PathFuncs)
+			return linuxType
 		},
 	)
 }

configurer/linux/archlinux.go

@@ -19,7 +19,9 @@ func init() {
 			return os.ID == "arch" || os.IDLike == "arch"
 		},
 		func() interface{} {
-			return &Archlinux{}
+			linuxType := &Archlinux{}
+			linuxType.PathFuncs = interface{}(linuxType).(configurer.PathFuncs)
+			return linuxType
 		},
 	)
 }

configurer/linux/debian.go

@@ -19,7 +19,9 @@ func init() {
 			return os.ID == "debian"
 		},
 		func() interface{} {
-			return &Debian{}
+			linuxType := &Debian{}
+			linuxType.PathFuncs = interface{}(linuxType).(configurer.PathFuncs)
+			return linuxType
 		},
 	)
 }

configurer/linux/enterpriselinux/almalinux.go

@@ -19,7 +19,9 @@ func init() {
 			return os.ID == "almalinux"
 		},
 		func() interface{} {
-			return AlmaLinux{}
+			linuxType := &AlmaLinux{}
+			linuxType.PathFuncs = interface{}(linuxType).(configurer.PathFuncs)
+			return linuxType
 		},
 	)
 }

configurer/linux/enterpriselinux/amazon.go

@@ -27,7 +27,9 @@ func init() {
 			return os.ID == "amzn"
 		},
 		func() interface{} {
-			return AmazonLinux{}
+			linuxType := &AmazonLinux{}
+			linuxType.PathFuncs = interface{}(linuxType).(configurer.PathFuncs)
+			return linuxType
 		},
 	)
 }

configurer/linux/enterpriselinux/centos.go

@@ -19,7 +19,9 @@ func init() {
 			return os.ID == "centos"
 		},
 		func() interface{} {
-			return CentOS{}
+			linuxType := &CentOS{}
+			linuxType.PathFuncs = interface{}(linuxType).(configurer.PathFuncs)
+			return linuxType
 		},
 	)
 }

configurer/linux/enterpriselinux/fedora.go

@@ -19,7 +19,9 @@ func init() {
 			return os.ID == "fedora"
 		},
 		func() interface{} {
-			return Fedora{}
+			linuxType := &Fedora{}
+			linuxType.PathFuncs = interface{}(linuxType).(configurer.PathFuncs)
+			return linuxType
 		},
 	)
 }

configurer/linux/enterpriselinux/oracle.go

@@ -19,7 +19,9 @@ func init() {
 			return os.ID == "ol"
 		},
 		func() interface{} {
-			return OracleLinux{}
+			linuxType := &OracleLinux{}
+			linuxType.PathFuncs = interface{}(linuxType).(configurer.PathFuncs)
+			return linuxType
 		},
 	)
 }

configurer/linux/enterpriselinux/rhel.go

@@ -1,6 +1,7 @@
 package enterpriselinux
 
 import (
+	"github.com/k0sproject/k0sctl/configurer"
 	k0slinux "github.com/k0sproject/k0sctl/configurer/linux"
 	"github.com/k0sproject/rig"
 	"github.com/k0sproject/rig/os/registry"
@@ -17,7 +18,9 @@ func init() {
 			return os.ID == "rhel"
 		},
 		func() interface{} {
-			return RHEL{}
+			linuxType := &RHEL{}
+			linuxType.PathFuncs = interface{}(linuxType).(configurer.PathFuncs)
+			return linuxType
 		},
 	)
 }