Fix linter errors

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>

Author: brandond

.golangci.json

@@ -0,0 +1,57 @@
+issues:
+  max-issues-per-linter: 1000
+  max-same-issues: 100
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+linters:
+  default: none
+  enable:
+    - govet
+    - revive
+  settings:
+    revive:
+      enable-all-rules: true
+      rules:
+        - {name: add-constant, disabled: true}
+        - {name: argument-limit, disabled: true}
+        - {name: cognitive-complexity, disabled: true}
+        - {name: confusing-naming, disabled: true}
+        - {name: confusing-results, disabled: true}
+        - {name: cyclomatic, disabled: true}
+        - {name: early-return, disabled: true}
+        - {name: empty-block, disabled: true}
+        - {name: enforce-switch-style, disabled: true}
+        - {name: flag-parameter, disabled: true}
+        - {name: function-length, disabled: true}
+        - {name: function-result-limit, disabled: true}
+        - {name: import-shadowing, disabled: true}
+        - {name: line-length-limit, disabled: true}
+        - {name: max-control-nesting, disabled: true}
+        - {name: max-public-structs, disabled: true}
+        - {name: redundant-import-alias, disabled: true}
+        - {name: unsecure-url-scheme, disabled: true}
+        - {name: unused-parameter, disabled: true}
+        - {name: unused-receiver, disabled: true}
+        - {name: use-waitgroup-go, disabled: true}
+        - {name: var-naming, disabled: true}
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+      - tests/
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+version: "2"

.golangci.yml

@@ -1,5 +1,7 @@
 package v1
 
+//revive:disable:struct-tag
+
 import (
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/apis/helm.cattle.io/v1/types.go

@@ -16,7 +16,7 @@ func main() {
 		Boilerplate:   "scripts/boilerplate.go.txt",
 		Groups: map[string]args.Group{
 			"helm.cattle.io": {
-				Types: []interface{}{
+				Types: []any{
 					v1.HelmChart{},
 					v1.HelmChartConfig{},
 				},

pkg/codegen/main.go

@@ -119,7 +119,6 @@ func Register(
 	cm corecontroller.ConfigMapController,
 	s corecontroller.SecretController,
 	sCache corecontroller.SecretCache) {
-
 	c := &Controller{
 		systemNamespace: systemNamespace,
 		jobClusterRole:  jobClusterRole,
@@ -184,7 +183,7 @@ func Register(
 func (c *Controller) jobPatcher(namespace, name string, pt types.PatchType, data []byte) (runtime.Object, error) {
 	err := c.jobs.Delete(namespace, name, &metav1.DeleteOptions{PropagationPolicy: &deletePolicy})
 	if err == nil || apierrors.IsNotFound(err) {
-		return nil, fmt.Errorf("create or replace job")
+		return nil, errors.New("create or replace job")
 	}
 	return nil, err
 }

pkg/controllers/chart/chart.go

@@ -2,6 +2,7 @@ package crds
 
 import (
 	"embed"
+	"errors"
 	"fmt"
 	"path"
 
@@ -18,7 +19,7 @@ var (
 	//go:embed yaml
 	crdFS embed.FS
 
-	errDuplicate = fmt.Errorf("duplicate CRD")
+	errDuplicate = errors.New("duplicate CRD")
 )
 
 func List() ([]*apiextv1.CustomResourceDefinition, error) {

pkg/crds/crds.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/base64"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -108,7 +109,6 @@ func (f *Framework) beforeFramework() {
 	f.ClientExt = clientext
 	f.Name = common.Name
 	f.Namespace = common.Name
-
 }
 
 func errExit(msg string, err error) {
@@ -192,7 +192,7 @@ func (f *Framework) UpdateHelmChart(chart *v1.HelmChart, namespace string) (upda
 	}); err != nil {
 		updated = nil
 	}
-	return
+	return updated, err
 }
 
 func (f *Framework) DeleteHelmChart(name, namespace string) error {
@@ -246,7 +246,7 @@ func (f *Framework) ListChartPods(chart *v1.HelmChart, appName string) ([]corev1
 
 func (f *Framework) GetJob(chart *v1.HelmChart) (*batchv1.Job, error) {
 	if chart.Status.JobName == "" {
-		return nil, fmt.Errorf("waiting for job name to be populated")
+		return nil, errors.New("waiting for job name to be populated")
 	}
 	r, err := f.ClientSet.BatchV1().Jobs(chart.Namespace).Get(context.TODO(), chart.Status.JobName, metav1.GetOptions{})
 	if err != nil {

test/framework/framework.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"time"
 
+	//revive:disable:dot-imports
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	batchv1 "k8s.io/api/batch/v1"
@@ -499,7 +500,6 @@ var _ = Describe("HelmChart Controller Tests", Ordered, func() {
 
 			Eventually(framework.ListReleases, 120*time.Second, 5*time.Second).WithArguments(chart).Should(HaveLen(0))
 		})
-
 	})
 
 	Context("When a HelmChart creates a namespace", func() {

test/suite/helm_test.go

@@ -3,6 +3,7 @@ package suite_test
 import (
 	"testing"
 
+	//revive:disable:dot-imports
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )