add test for getvmfromuuid()

Author: sp-yduck

go.mod

@@ -6,6 +6,7 @@ require (
 	github.com/pkg/errors v0.9.1
 	github.com/sp-yduck/proxmox-go v0.0.0-alpha1
 	github.com/spf13/pflag v1.0.5
+	github.com/stretchr/testify v1.8.4
 	gopkg.in/yaml.v3 v3.0.1
 	k8s.io/api v0.27.3
 	k8s.io/apimachinery v0.27.3
@@ -60,6 +61,7 @@ require (
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
 	github.com/onsi/ginkgo/v2 v2.9.5 // indirect
 	github.com/onsi/gomega v1.27.7 // indirect
+	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/prometheus/client_golang v1.15.1 // indirect
 	github.com/prometheus/client_model v0.4.0 // indirect
 	github.com/prometheus/common v0.42.0 // indirect

go.sum

@@ -283,6 +283,7 @@ github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
 github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
 github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
 github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
+github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
 github.com/tmc/grpc-websocket-proxy v0.0.0-20220101234140-673ab2c3ae75 h1:6fotK7otjonDflCTK0BCfls4SPy3NcCVb5dqqmbRknE=
 github.com/xiang90/probing v0.0.0-20190116061207-43a291ad63a2 h1:eY9dn8+vbi4tKz5Qo6v2eYzo7kUS51QINcR5jNpbZS8=
 github.com/yuin/goldmark v1.1.25/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=

pkg/cloudprovider/cloud.go

@@ -41,13 +41,13 @@ type proxmoxConfig struct {
 func init() {
 	klog.Info("registering cloud provider")
 
-	cloudprovider.RegisterCloudProvider(RegisteredProviderName, func(config io.Reader) (cloudprovider.Interface, error) {
-		providerConfig, err := readCloudProviderConfig(config)
-		if err != nil {
-			return nil, err
-		}
-		return newCloud(providerConfig)
-	})
+	// cloudprovider.RegisterCloudProvider(RegisteredProviderName, func(config io.Reader) (cloudprovider.Interface, error) {
+	// 	providerConfig, err := readCloudProviderConfig(config)
+	// 	if err != nil {
+	// 		return nil, err
+	// 	}
+	// 	return newCloud(providerConfig)
+	// })
 }
 
 func newCloud(config *cloudProviderConfig) (cloudprovider.Interface, error) {

pkg/cloudprovider/instances.go

@@ -9,6 +9,7 @@ import (
 	"regexp"
 	"strings"
 
+	"github.com/sp-yduck/proxmox-go/api"
 	"github.com/sp-yduck/proxmox-go/rest"
 	v1 "k8s.io/api/core/v1"
 	cloudprovider "k8s.io/cloud-provider"
@@ -41,31 +42,43 @@ func newInstances(config proxmoxConfig) (cloudprovider.InstancesV2, error) {
 func (i *instance) InstanceExists(ctc context.Context, node *v1.Node) (bool, error) {
 	klog.Info("checking if instance exists (node=%s)", node.Name)
 
-	nodes, err := i.compute.GetNodes()
+	_, err := i.getVMFromUUID(node.Status.NodeInfo.SystemUUID)
 	if err != nil {
+		if rest.IsNotFound(err) {
+			return false, nil
+		}
 		return true, err
 	}
+
+	return true, nil
+}
+
+func (i *instance) getVMFromUUID(uuid string) (*api.VirtualMachine, error) {
+	nodes, err := i.compute.GetNodes()
+	if err != nil {
+		return nil, err
+	}
 	for _, n := range nodes {
 		vms, err := i.compute.GetVirtualMachines(n.Node)
 		if err != nil {
-			return true, err
+			return nil, err
 		}
 		for _, vm := range vms {
 			config, err := i.compute.GetVirtualMachineConfig(n.Node, vm.VMID)
 			if err != nil {
-				return true, err
+				return nil, err
 			}
 			smbios := config.SMBios1
-			uuid, err := convertSMBiosToUUID(smbios)
+			vmuuid, err := convertSMBiosToUUID(smbios)
 			if err != nil {
-				return true, err
+				return nil, err
 			}
-			if uuid == node.Status.NodeInfo.SystemUUID {
-				return true, nil
+			if vmuuid == uuid {
+				return vm, nil
 			}
 		}
 	}
-	return false, nil
+	return nil, rest.NotFoundErr
 }
 
 func convertSMBiosToUUID(smbios string) (string, error) {

pkg/cloudprovider/instances_test.go

@@ -0,0 +1,20 @@
+package proxmox
+
+import (
+	"github.com/sp-yduck/proxmox-go/rest"
+)
+
+func (s *TestSuite) TestGetVMFromUUID() {
+	uuid := "cefbe890-bc88-4faa-82d1-a33915d71d1d"
+
+	vm, err := s.instance.getVMFromUUID(uuid)
+	if err != nil {
+		if rest.IsNotFound(err) {
+			s.T().Logf("not found vm having uuid=%s", uuid)
+			return
+		}
+		s.T().Fatalf("failed to get vm from uuid: %v", err)
+
+	}
+	s.T().Logf("get vm having uuid=%s: %v", uuid, *vm)
+}

pkg/cloudprovider/suite_test.go

@@ -0,0 +1,48 @@
+package proxmox
+
+import (
+	"crypto/tls"
+	"net/http"
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/suite"
+
+	"github.com/sp-yduck/proxmox-go/rest"
+)
+
+type TestSuite struct {
+	suite.Suite
+	instance instance
+}
+
+func (s *TestSuite) SetupSuite() {
+	url := os.Getenv("PROXMOX_URL")
+	user := os.Getenv("PROXMOX_USERNAME")
+	password := os.Getenv("PROXMOX_PASSWORD")
+	if url == "" || user == "" || password == "" {
+		s.T().Fatalf("following env var must not be empty: PROXMOX_URL=%s, POXMOX_USERNAME=%s, PROXOMOX_PASSWORD=%s", url, user, password)
+	}
+
+	base := http.Client{
+		Transport: &http.Transport{
+			TLSClientConfig: &tls.Config{
+				InsecureSkipVerify: true,
+			},
+		},
+	}
+
+	restclient, err := rest.NewRESTClient(url, rest.WithUserPassword(user, password), rest.WithClient(&base))
+	if err != nil {
+		s.T().Logf("url=%s", url)
+		s.T().Logf("user=%s", user)
+		s.T().Logf("password=%s", password)
+		s.T().Fatalf("failed to create rest client: %v", err)
+	}
+
+	s.instance.compute = restclient
+}
+
+func TestSuiteIntegration(t *testing.T) {
+	suite.Run(t, new(TestSuite))
+}