clean: remove trivial comments

Author: btouchard

README.md

@@ -55,31 +55,31 @@ Display your SHM metrics in your README with embeddable SVG badges.
 
 #### Active Instances
 
-![Instances Badge](https://your-shm-server.example.com/badge/your-app/instances)
 
+![Instances](https://img.shields.io/badge/instances-260-00D084?style=flat-square)
 ```markdown
 ![Instances](https://your-shm-server.example.com/badge/your-app/instances)
 ```
 
 #### Most Used Version
 
-![Version Badge](https://your-shm-server.example.com/badge/your-app/version)
+![Version](https://img.shields.io/badge/version-1.2.0-8B5CF6?style=flat-square)
 
 ```markdown
 ![Version](https://your-shm-server.example.com/badge/your-app/version)
 ```
 
 #### Aggregated Metrics
 
-![Users Badge](https://your-shm-server.example.com/badge/your-app/metric/users_count)
+![Users](https://img.shields.io/badge/users-1.2k-00D084?style=flat-square)
 
 ```markdown
 ![Users](https://your-shm-server.example.com/badge/your-app/metric/users_count)
 ```
 
 #### Combined Stats
 
-![Adoption Badge](https://your-shm-server.example.com/badge/your-app/combined?metric=users_count)
+![Adoption](https://img.shields.io/badge/adoption-1.2k%20%2F%2042-6366F1?style=flat-square)
 
 ```markdown
 ![Adoption](https://your-shm-server.example.com/badge/your-app/combined?metric=users_count)

internal/adapters/http/badge.go

@@ -9,54 +9,41 @@ import (
 	"github.com/btouchard/shm/internal/services/badge"
 )
 
-// BadgeInstances generates a badge showing the number of active instances.
-// GET /badge/{app-slug}/instances
 func (h *Handlers) BadgeInstances(w http.ResponseWriter, r *http.Request) {
-	// Extract app slug from path
 	appSlug := extractSlugFromPath(r.URL.Path, "/badge/", "/instances")
 	if appSlug == "" {
 		renderErrorBadge(w, "invalid slug")
 		return
 	}
 
-	// Get active instances count
 	count, err := h.dashboard.GetActiveInstancesCount(r.Context(), appSlug)
 	if err != nil {
 		h.logger.Warn("failed to get instances count", "slug", appSlug, "error", err)
 		renderErrorBadge(w, "error")
 		return
 	}
 
-	// Determine color based on count
 	color := badge.GetInstancesColor(count)
-
-	// Allow custom color via query param
 	if customColor := r.URL.Query().Get("color"); customColor != "" {
 		color = "#" + strings.TrimPrefix(customColor, "#")
 	}
 
-	// Allow custom label
 	label := r.URL.Query().Get("label")
 	if label == "" {
 		label = "instances"
 	}
 
-	// Generate badge
 	b := badge.NewBadge(label, badge.FormatNumber(float64(count)), color)
 	renderSVGBadge(w, b.ToSVG())
 }
 
-// BadgeVersion generates a badge showing the most used version.
-// GET /badge/{app-slug}/version
 func (h *Handlers) BadgeVersion(w http.ResponseWriter, r *http.Request) {
-	// Extract app slug from path
 	appSlug := extractSlugFromPath(r.URL.Path, "/badge/", "/version")
 	if appSlug == "" {
 		renderErrorBadge(w, "invalid slug")
 		return
 	}
 
-	// Get most used version
 	version, err := h.dashboard.GetMostUsedVersion(r.Context(), appSlug)
 	if err != nil {
 		h.logger.Warn("failed to get version", "slug", appSlug, "error", err)
@@ -68,28 +55,21 @@ func (h *Handlers) BadgeVersion(w http.ResponseWriter, r *http.Request) {
 		version = "no data"
 	}
 
-	// Allow custom color via query param
 	color := badge.ColorPurple
 	if customColor := r.URL.Query().Get("color"); customColor != "" {
 		color = "#" + strings.TrimPrefix(customColor, "#")
 	}
 
-	// Allow custom label
 	label := r.URL.Query().Get("label")
 	if label == "" {
 		label = "version"
 	}
 
-	// Generate badge
 	b := badge.NewBadge(label, version, color)
 	renderSVGBadge(w, b.ToSVG())
 }
 
-// BadgeMetric generates a badge showing an aggregated metric value.
-// GET /badge/{app-slug}/metric/{metric-name}
 func (h *Handlers) BadgeMetric(w http.ResponseWriter, r *http.Request) {
-	// Extract app slug and metric name from path
-	// Path format: /badge/{slug}/metric/{name}
 	parts := strings.Split(strings.TrimPrefix(r.URL.Path, "/badge/"), "/")
 	if len(parts) < 3 || parts[1] != "metric" {
 		renderErrorBadge(w, "invalid path")
@@ -104,96 +84,74 @@ func (h *Handlers) BadgeMetric(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	// Get aggregated metric
 	value, err := h.dashboard.GetAggregatedMetric(r.Context(), appSlug, metricName)
 	if err != nil {
 		h.logger.Warn("failed to get metric", "slug", appSlug, "metric", metricName, "error", err)
 		renderErrorBadge(w, "error")
 		return
 	}
 
-	// Determine color based on value
 	color := badge.GetMetricColor(value)
-
-	// Allow custom color via query param
 	if customColor := r.URL.Query().Get("color"); customColor != "" {
 		color = "#" + strings.TrimPrefix(customColor, "#")
 	}
 
-	// Allow custom label
 	label := r.URL.Query().Get("label")
 	if label == "" {
 		label = metricName
 	}
 
-	// Generate badge
 	b := badge.NewBadge(label, badge.FormatNumber(value), color)
 	renderSVGBadge(w, b.ToSVG())
 }
 
-// BadgeCombined generates a combined badge showing metric value and instance count.
-// GET /badge/{app-slug}/combined?metric=users_count
 func (h *Handlers) BadgeCombined(w http.ResponseWriter, r *http.Request) {
-	// Extract app slug from path
 	appSlug := extractSlugFromPath(r.URL.Path, "/badge/", "/combined")
 	if appSlug == "" {
 		renderErrorBadge(w, "invalid slug")
 		return
 	}
 
-	// Get metric name from query param (default: users_count)
 	metricName := r.URL.Query().Get("metric")
 	if metricName == "" {
 		metricName = "users_count"
 	}
 
-	// Get combined stats
 	metricValue, instanceCount, err := h.dashboard.GetCombinedStats(r.Context(), appSlug, metricName)
 	if err != nil {
 		h.logger.Warn("failed to get combined stats", "slug", appSlug, "metric", metricName, "error", err)
 		renderErrorBadge(w, "error")
 		return
 	}
 
-	// Allow custom color
 	color := badge.ColorIndigo
 	if customColor := r.URL.Query().Get("color"); customColor != "" {
 		color = "#" + strings.TrimPrefix(customColor, "#")
 	}
 
-	// Allow custom label
 	label := r.URL.Query().Get("label")
 	if label == "" {
 		label = "adoption"
 	}
 
-	// Format compact: "1.2k / 42"
 	value := badge.FormatNumber(metricValue) + " / " + badge.FormatNumber(float64(instanceCount))
-
-	// Generate badge
 	b := badge.NewBadge(label, value, color)
 	renderSVGBadge(w, b.ToSVG())
 }
 
-// Helper functions
-
-// extractSlugFromPath extracts the app slug from a badge path.
-// Example: /badge/my-app/instances -> "my-app"
 func extractSlugFromPath(path, prefix, suffix string) string {
 	s := strings.TrimPrefix(path, prefix)
 	s = strings.TrimSuffix(s, suffix)
 	return s
 }
 
-// renderSVGBadge writes an SVG badge to the response with proper headers.
 func renderSVGBadge(w http.ResponseWriter, svg string) {
 	w.Header().Set("Content-Type", "image/svg+xml;charset=utf-8")
-	w.Header().Set("Cache-Control", "public, max-age=300") // 5 minutes cache
+	w.Header().Set("Cache-Control", "public, max-age=300")
 	w.WriteHeader(http.StatusOK)
 	_, _ = w.Write([]byte(svg))
 }
 
-// renderErrorBadge renders an error badge.
 func renderErrorBadge(w http.ResponseWriter, message string) {
 	b := badge.NewBadge("error", message, badge.ColorRed)
 	renderSVGBadge(w, b.ToSVG())

internal/adapters/http/router.go

@@ -30,41 +30,29 @@ func NewRouter(cfg RouterConfig) *http.ServeMux {
 		logger = slog.Default()
 	}
 
-	// Create repositories from store
 	instanceRepo := cfg.Store.InstanceRepository()
 	snapshotRepo := cfg.Store.SnapshotRepository()
 	applicationRepo := cfg.Store.ApplicationRepository()
 	dashboardReader := cfg.Store.DashboardReader()
 
-	// Create GitHub service
 	githubSvc := github.NewStarsService(cfg.GitHubToken)
 	githubSvc.StartCleanup(context.Background())
 
-	// Create application services
 	applicationSvc := app.NewApplicationService(applicationRepo, githubSvc, logger)
 	instanceSvc := app.NewInstanceService(instanceRepo, applicationSvc)
 	snapshotSvc := app.NewSnapshotService(snapshotRepo, instanceRepo)
 	dashboardSvc := app.NewDashboardService(dashboardReader)
 
-	// Start background scheduler for GitHub stars refresh
 	scheduler := services.NewScheduler(applicationSvc, logger)
 	go scheduler.Start(context.Background())
 
-	// Create HTTP handlers
 	handlers := NewHandlers(instanceSvc, snapshotSvc, applicationSvc, dashboardSvc, logger)
-
-	// Create auth middleware
 	authMW := NewAuthMiddlewareFromService(instanceSvc, logger)
-
-	// Create router
 	mux := http.NewServeMux()
 
-	// Health check (no auth, no rate limit)
 	mux.HandleFunc("/api/v1/healthcheck", handlers.Healthcheck)
 
-	// Badge endpoints (public, no auth, no rate limit)
 	mux.HandleFunc("/badge/", func(w http.ResponseWriter, r *http.Request) {
-		// Route to appropriate badge handler based on path suffix
 		path := r.URL.Path
 		switch {
 		case strings.HasSuffix(path, "/instances"):
@@ -80,33 +68,25 @@ func NewRouter(cfg RouterConfig) *http.ServeMux {
 		}
 	})
 
-	// Client endpoints
 	rl := cfg.RateLimiter
 	if rl != nil {
 		mux.HandleFunc("/v1/register", rl.RegisterMiddleware(handlers.Register))
 		mux.HandleFunc("/v1/activate", rl.RegisterMiddleware(authMW.RequireSignature(handlers.Activate)))
 		mux.HandleFunc("/v1/snapshot", rl.SnapshotMiddleware(authMW.RequireSignature(handlers.Snapshot)))
-
-		// Admin endpoints
 		mux.HandleFunc("/api/v1/admin/stats", rl.AdminMiddleware(handlers.AdminStats))
 		mux.HandleFunc("/api/v1/admin/instances", rl.AdminMiddleware(handlers.AdminInstances))
 		mux.HandleFunc("/api/v1/admin/metrics/", rl.AdminMiddleware(handlers.AdminMetrics))
-
-		// Application endpoints
 		mux.HandleFunc("/api/v1/admin/applications", rl.AdminMiddleware(handlers.AdminListApplications))
 		mux.HandleFunc("/api/v1/admin/applications/", rl.AdminMiddleware(func(w http.ResponseWriter, r *http.Request) {
-			// Route to appropriate handler based on path suffix
 			if r.URL.Path == "/api/v1/admin/applications/" {
 				handlers.AdminListApplications(w, r)
 				return
 			}
-			// Check if it's a refresh-stars request
 			if len(r.URL.Path) > len("/api/v1/admin/applications/") &&
 			   r.URL.Path[len(r.URL.Path)-len("/refresh-stars"):] == "/refresh-stars" {
 				handlers.AdminRefreshStars(w, r)
 				return
 			}
-			// Otherwise, treat as get/update application
 			if r.Method == http.MethodGet {
 				handlers.AdminGetApplication(w, r)
 			} else if r.Method == http.MethodPut {
@@ -116,15 +96,12 @@ func NewRouter(cfg RouterConfig) *http.ServeMux {
 			}
 		}))
 	} else {
-		// No rate limiting (for testing)
 		mux.HandleFunc("/v1/register", handlers.Register)
 		mux.HandleFunc("/v1/activate", authMW.RequireSignature(handlers.Activate))
 		mux.HandleFunc("/v1/snapshot", authMW.RequireSignature(handlers.Snapshot))
 		mux.HandleFunc("/api/v1/admin/stats", handlers.AdminStats)
 		mux.HandleFunc("/api/v1/admin/instances", handlers.AdminInstances)
 		mux.HandleFunc("/api/v1/admin/metrics/", handlers.AdminMetrics)
-
-		// Application endpoints
 		mux.HandleFunc("/api/v1/admin/applications", handlers.AdminListApplications)
 		mux.HandleFunc("/api/v1/admin/applications/", func(w http.ResponseWriter, r *http.Request) {
 			if r.URL.Path == "/api/v1/admin/applications/" {

internal/services/badge/colors.go

@@ -2,23 +2,18 @@
 
 package badge
 
-// Color palette for badges - custom and original
 const (
-	// Label background (left side)
-	ColorLabel = "#404040"
-
-	// Status colors (right side)
-	ColorGreen   = "#00D084" // Success, high numbers
-	ColorBlue    = "#3B82F6" // Info, neutral
-	ColorYellow  = "#F59E0B" // Warning, medium numbers
-	ColorRed     = "#EF4444" // Error, low numbers
-	ColorPurple  = "#8B5CF6" // Special, version info
-	ColorGray    = "#6B7280" // Inactive, no data
-	ColorTeal    = "#14B8A6" // Custom metrics
-	ColorIndigo  = "#6366F1" // Combined stats
+	ColorLabel  = "#555"
+	ColorGreen  = "#00D084"
+	ColorBlue   = "#3B82F6"
+	ColorYellow = "#F59E0B"
+	ColorRed    = "#EF4444"
+	ColorPurple = "#8B5CF6"
+	ColorGray   = "#6B7280"
+	ColorTeal   = "#14B8A6"
+	ColorIndigo = "#6366F1"
 )
 
-// GetInstancesColor returns the appropriate color based on instance count.
 func GetInstancesColor(count int) string {
 	switch {
 	case count >= 10:
@@ -30,8 +25,6 @@ func GetInstancesColor(count int) string {
 	}
 }
 
-// GetMetricColor returns the color for a custom metric based on value.
-// This is a simple heuristic - adjust based on your needs.
 func GetMetricColor(value float64) string {
 	switch {
 	case value >= 1000: