Skip to content

Commit 436f64e

Browse files
authored
Merge pull request #130 from zvlb/main
fix error with find actual secret with certificate for virtual service
2 parents ede5745 + b5e5e00 commit 436f64e

File tree

5 files changed

+114
-91
lines changed

5 files changed

+114
-91
lines changed

api/v1alpha1/virtualservice_methods.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,19 @@ func (vs *VirtualService) SetValid(ctx context.Context, cl client.Client) error
5050
}
5151

5252
func (vs *VirtualService) SetValidWithUsedSecrets(ctx context.Context, cl client.Client, secrets []string) error {
53+
err := vs.setUsedSecrets(secrets)
54+
if err != nil {
55+
return err
56+
}
57+
5358
if vs.Status.Valid != nil && *vs.Status.Valid {
54-
return nil
59+
return cl.Status().Update(ctx, vs.DeepCopy())
5560
}
61+
5662
valid := true
5763
vs.Status.Valid = &valid
5864
vs.Status.Error = nil
5965

60-
err := vs.setUsedSecrets(secrets)
61-
if err != nil {
62-
return err
63-
}
64-
6566
return cl.Status().Update(ctx, vs.DeepCopy())
6667
}
6768

helm/charts/envoy-xds-controller/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ type: application
1515
# This is the chart version. This version number should be incremented each time you make changes
1616
# to the chart and its templates, including the app version.
1717
# Versions are expected to follow Semantic Versioning (https://semver.org/)
18-
version: "0.56"
18+
version: "0.57"
1919

2020
# This is the version number of the application being deployed. This version number should be
2121
# incremented each time you make changes to the application. Versions are not expected to
2222
# follow Semantic Versioning. They should reflect the version the application is using.
2323
# It is recommended to use it with quotes.
24-
appVersion: "v0.2.0"
24+
appVersion: "v0.2.1"
2525

2626
home: https://github.com/kaasops/envoy-xds-controller
2727
sources:

0 commit comments

Comments
 (0)