Skip to content

Commit 43b4fbb

Browse files
authored
Fix build-args not being passed in CI due to boolean vs string comparison (#214)
1 parent 577c983 commit 43b4fbb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/build-image.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ jobs:
6969
platforms: linux/amd64,linux/arm64
7070
push: true
7171
build-args: |
72-
${{ matrix.build-args == 'true' && format('VERSION={0}', steps.tag.outputs.TAG) || '' }}
73-
${{ matrix.build-args == 'true' && format('COMMIT_HASH={0}', github.sha) || '' }}
74-
${{ matrix.build-args == 'true' && format('BUILD_DATE={0}', steps.date.outputs.BUILD_DATE) || '' }}
72+
${{ matrix.build-args && format('VERSION={0}', steps.tag.outputs.TAG) || '' }}
73+
${{ matrix.build-args && format('COMMIT_HASH={0}', github.sha) || '' }}
74+
${{ matrix.build-args && format('BUILD_DATE={0}', steps.date.outputs.BUILD_DATE) || '' }}
7575
tags: ${{ secrets.DOCKERHUB_USERNAME }}/${{ github.event.repository.name }}${{ matrix.suffix }}:${{ steps.tag.outputs.TAG }},${{ secrets.DOCKERHUB_USERNAME }}/${{ github.event.repository.name }}${{ matrix.suffix }}:latest
7676
cache-from: type=registry,ref=${{ secrets.DOCKERHUB_USERNAME }}/${{ github.event.repository.name }}${{ matrix.suffix }}:buildcache
7777
cache-to: type=registry,ref=${{ secrets.DOCKERHUB_USERNAME }}/${{ github.event.repository.name }}${{ matrix.suffix }}:buildcache,mode=max

0 commit comments

Comments
 (0)