tests: add empty domain validation in virtual service

Author: zvlb

api/v1alpha1/virtualservice_webhook.go

@@ -60,6 +60,10 @@ func (vs *VirtualService) Validate(
 		return errors.Wrap(err, errors.UnmarshalMessage)
 	}
 
+	if err := vh.ValidateAll(); err != nil {
+		return errors.WrapUKS(err, errors.CannotValidateCacheResourceMessage)
+	}
+
 	// Check AccessLog spec
 	if vs.Spec.AccessLog != nil {
 		al := &accesslogv3.AccessLog{}

test/conformance/tests/virtualService.go

@@ -23,6 +23,7 @@ func init() {
 		VirtualService_SaveSecretWithCertificate_SecretRef,
 		VirtualService_SaveSecretWithCertificate_SecretRef_DiferentNamespaces,
 		VirtualService_SaveSecretWithCertificate_AutoDiscovery_DiferentNamespaces,
+		VirtualService_EmptyDomains,
 	)
 }
 
@@ -42,6 +43,14 @@ var VirtualService_InvalidVirtualHost = utils.TestCase{
 	Test:               func(t *testing.T, suite *utils.TestSuite) {},
 }
 
+var VirtualService_EmptyDomains = utils.TestCase{
+	ShortName:          "VirtualService_EmptyDomains",
+	Description:        "Test that the VirtualService cannot be applied with empty domains in VirtualHost spec",
+	Manifests:          []string{"../testdata/conformance/virtualservice-empty-domains.yaml"},
+	ApplyErrorContains: fmt.Sprintf("%v%v", ValidationErrorMessage, errors.CannotValidateCacheResourceMessage),
+	Test:               func(t *testing.T, suite *utils.TestSuite) {},
+}
+
 var VirtualService_SaveSecretWithCertificate_SecretRef = utils.TestCase{
 	ShortName:          "VirtualService_SaveSecretWithSertificate_SecretRef",
 	Description:        "Test that the secret with sertificate cannot be deleted if used in VirtualService with tlsConfig.SecretRef",

test/testdata/conformance/virtualservice-empty-domains.yaml

@@ -0,0 +1,16 @@
+apiVersion: envoy.kaasops.io/v1alpha1
+kind: VirtualService
+metadata:
+  name: virtual-service-empty-domains
+spec:
+  listener:
+    name: http
+  additionalRoutes:
+    - name: static
+  virtualHost:
+    name: test-domain
+    routes:
+      - match:
+          prefix: /
+        route:
+          cluster: static