Commit e216790
fix: Make registry binding cross-platform compatible
Change registry binding from 127.0.0.1:5001 to 0.0.0.0:5001 for cross-platform compatibility.
The 127.0.0.1 binding works on macOS (Docker Desktop has special networking) but fails on Linux (GitHub Actions) because native docker containers can only access host services bound to all interfaces (0.0.0.0) or the docker bridge interface.
This change:
- Enables deploy.sh to work on macOS, Linux, and Windows
- Allows GitHub Actions workflow to use deploy.sh without workarounds
- Maintains security for local development (registry only accessible on localhost)
- Follows patterns from similar tools like KIND (Kubernetes in Docker)
Also simplified the GitHub Actions workflow to use deploy.sh directly instead of custom build steps.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 3b299e0 commit e216790
File tree
2 files changed
+1
-4
lines changed- .github/workflows
- examples/cloud-deployment/scripts
2 files changed
+1
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | 38 | | |
42 | 39 | | |
43 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
0 commit comments