Merge pull request #6 from kabisa/fix-dependency-existance-for-slos

fixed dependency issues for slo burn rates, they needed slo to exist

Author: obeleh

errors-slo.tf

@@ -15,9 +15,10 @@ locals {
     var.error_slo_burn_rate_notification_channel_override,
     var.notification_channel
   ), "")
+  error_slo_burn_rate_enabled = var.error_slo_enabled && var.error_slo_burn_rate_enabled
+  error_slo_id = local.error_slo_burn_rate_enabled ? datadog_service_level_objective.error_slo[0].id : ""
 }
 
-
 resource "datadog_service_level_objective" "error_slo" {
   count       = var.error_slo_enabled ? 1 : 0
   name        = "${local.service_display_name} - APM - Error SLO"
@@ -43,7 +44,7 @@ module "error_slo_burn_rate" {
   version = "0.7.4"
 
   name  = "APM - Error SLO - Burn Rate"
-  query = "burn_rate(\"${datadog_service_level_objective.error_slo[0].id}\").over(\"${var.error_slo_burn_rate_evaluation_period}\").long_window(\"${var.error_slo_burn_rate_long_window}\").short_window(\"${var.error_slo_burn_rate_short_window}\") > ${var.error_slo_burn_rate_critical}"
+  query = "burn_rate(\"${local.error_slo_id}\").over(\"${var.error_slo_burn_rate_evaluation_period}\").long_window(\"${var.error_slo_burn_rate_long_window}\").short_window(\"${var.error_slo_burn_rate_short_window}\") > ${var.error_slo_burn_rate_critical}"
 
 
   alert_message    = "${local.service_display_name} service is burning through its Error Budget. The percentage of 5XX status codes is {{threshold}}x higher than expected"

latency-slo.tf

@@ -7,6 +7,8 @@ locals {
     var.latency_slo_burn_rate_notification_channel_override,
     var.notification_channel
   ), "")
+  latency_slo_burn_rate_enabled = var.latency_slo_enabled && var.latency_slo_burn_rate_enabled
+  latency_slo_id = local.latency_slo_burn_rate_enabled ? datadog_service_level_objective.latency_slo[0].id : ""
 }
 
 
@@ -36,15 +38,15 @@ module "latency_slo_burn_rate" {
   version = "0.7.4"
 
   name  = "APM - Latency SLO - Burn Rate"
-  query = "burn_rate(\"${datadog_service_level_objective.latency_slo[0].id}\").over(\"${var.latency_slo_burn_rate_evaluation_period}\").long_window(\"${var.latency_slo_burn_rate_long_window}\").short_window(\"${var.latency_slo_burn_rate_short_window}\") > ${var.latency_slo_burn_rate_critical}"
+  query = "burn_rate(\"${local.latency_slo_id}\").over(\"${var.latency_slo_burn_rate_evaluation_period}\").long_window(\"${var.latency_slo_burn_rate_long_window}\").short_window(\"${var.latency_slo_burn_rate_short_window}\") > ${var.latency_slo_burn_rate_critical}"
 
 
   alert_message    = "${local.service_display_name} service is burning through its Latency Budget. The percentage of slow requests is {{threshold}}x higher than expected"
   recovery_message = "${local.service_display_name} service burn rate has recovered"
   type             = "slo alert"
 
   # monitor level vars
-  enabled            = var.latency_slo_enabled && var.latency_slo_burn_rate_enabled
+  enabled            = local.latency_slo_burn_rate_enabled
   alerting_enabled   = var.latency_slo_burn_rate_alerting_enabled
   warning_threshold  = var.latency_slo_burn_rate_warning
   critical_threshold = var.latency_slo_burn_rate_critical