disabled latency and error alerts because we prefer SLOs for that

obeleh · obeleh · commit 6accf3e8be47 · 2022-06-30T13:43:57.000+02:00
diff --git a/README.md b/README.md
@@ -88,7 +88,7 @@ avg(last_10m):100 * (sum:trace.${var.trace_span_name}.errors{tag:xxx}.as_rate()
 
 | variable                           | default  | required | description                      |
 |------------------------------------|----------|----------|----------------------------------|
-| error_percentage_enabled           | True     | No       |                                  |
+| error_percentage_enabled           | False    | No       | We prefer to alert on SLO's      |
 | error_percentage_warning           | 0.01     | No       |                                  |
 | error_percentage_critical          | 0.05     | No       |                                  |
 | error_percentage_evaluation_period | last_10m | No       |                                  |
@@ -133,7 +133,7 @@ percentile(last_15m):p95:trace.${var.trace_span_name}{${local.latency_filter}} >
 
 | variable                                  | default  | required | description                      |
 |-------------------------------------------|----------|----------|----------------------------------|
-| latency_p95_enabled                       | True     | No       |                                  |
+| latency_p95_enabled                       | False    | No       | We prefer to alert on SLO's      |
 | latency_p95_warning                       | 0.9      | No       | P95 Latency in seconds.          |
 | latency_p95_critical                      | 1.3      | No       | P95 Latency warning in seconds.  |
 | latency_p95_evaluation_period             | last_15m | No       |                                  |
@@ -155,7 +155,7 @@ burn_rate(\"${local.latency_slo_id}\").over(\"${var.latency_slo_burn_rate_evalua
 
 | variable                                            | default                                  | required | description                                                                                          |
 |-----------------------------------------------------|------------------------------------------|----------|------------------------------------------------------------------------------------------------------|
-| latency_slo_enabled                                 | False                                    | No       | Note that this monitor requires custom metrics to be present. Those can unfortunately not be created with Terraform yet |
+| latency_slo_enabled                                 | True                                     | No       | Note that this monitor requires custom metrics to be present. Those can unfortunately not be created with Terraform yet |
 | latency_slo_note                                    | ""                                       | No       |                                                                                                      |
 | latency_slo_docs                                    | ""                                       | No       |                                                                                                      |
 | latency_slo_filter_override                         | ""                                       | No       |                                                                                                      |
diff --git a/error-percentage-variables.tf b/error-percentage-variables.tf
@@ -1,6 +1,7 @@
 variable "error_percentage_enabled" {
-  type    = bool
-  default = true
+  description = "We prefer to alert on SLO's"
+  type        = bool
+  default     = false
 }
 
 variable "error_percentage_warning" {
diff --git a/latency-p95-variables.tf b/latency-p95-variables.tf
@@ -1,6 +1,7 @@
 variable "latency_p95_enabled" {
-  type    = bool
-  default = true
+  description = "We prefer to alert on SLO's"
+  type        = bool
+  default     = false
 }
 
 variable "latency_p95_warning" {
diff --git a/latency-slo-variables.tf b/latency-slo-variables.tf
@@ -1,6 +1,6 @@
 variable "latency_slo_enabled" {
   type        = bool
-  default     = false
+  default     = true
   description = "Note that this monitor requires custom metrics to be present. Those can unfortunately not be created with Terraform yet"
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`variable "error_percentage_enabled" {`
`2`		`- type = bool`
`3`		`- default = true`
	`2`	`+ description = "We prefer to alert on SLO's"`
	`3`	`+ type = bool`
	`4`	`+ default = false`
`4`	`5`	`}`
`5`	`6`
`6`	`7`	`variable "error_percentage_warning" {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`variable "latency_p95_enabled" {`
`2`		`- type = bool`
`3`		`- default = true`
	`2`	`+ description = "We prefer to alert on SLO's"`
	`3`	`+ type = bool`
	`4`	`+ default = false`
`4`	`5`	`}`
`5`	`6`
`6`	`7`	`variable "latency_p95_warning" {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`variable "latency_slo_enabled" {`
`2`	`2`	`type = bool`
`3`		`- default = false`
	`3`	`+ default = true`
`4`	`4`	`description = "Note that this monitor requires custom metrics to be present. Those can unfortunately not be created with Terraform yet"`
`5`	`5`	`}`
`6`	`6`