housekeeping (#26)

* housekeeping

* add build with ghc-9.4

* add missing COMPLETE pragmas

* update outdated actions

* remove redundant imports

Author: larskuhtz

.github/workflows/build-application.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ghc: ['8.10.7', '9.0.2', '9.2']
+        ghc: ['8.10.7', '9.0.2', '9.2', '9.4']
         cabal: ['3.8']
         os: ['ubuntu-20.04', 'ubuntu-22.04', 'macOS-latest']
 
@@ -31,7 +31,7 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v3
     - name: Install GHC and Cabal
-      uses: haskell/actions/setup@v2.0.2
+      uses: haskell/actions/setup@v2
       with:
          ghc-version: ${{ matrix.ghc }}
          cabal-version: ${{ matrix.cabal }}
@@ -145,7 +145,7 @@ jobs:
 
     - name: Docker meta
       id: meta
-      uses: docker/metadata-action@v3
+      uses: docker/metadata-action@v4
       with:
         images: ghcr.io/kadena-io/chainweb-mining-client
         tags: |
@@ -163,7 +163,7 @@ jobs:
 
     - name: Build and push
       id: docker_build
-      uses: docker/build-push-action@v2
+      uses: docker/build-push-action@v4
       with:
         push: true
         context: .

main/Main.hs

@@ -32,7 +32,7 @@ import Configuration.Utils hiding (Error)
 import Control.Concurrent
 import Control.Concurrent.Async
 import Control.Concurrent.STM
-import Control.Exception (IOException, SomeAsyncException)
+import Control.Exception (IOException, SomeAsyncException, throwIO)
 import Control.Lens hiding ((.=))
 import Control.Monad
 import Control.Monad.Catch
@@ -551,9 +551,11 @@ postSolved :: Config -> ChainwebVersion -> Logger -> HTTP.Manager -> Work -> IO
 postSolved conf ver logger mgr (Work bytes) = retryHttp logger $ do
     logg Info "post solved worked"
     void (HTTP.httpLbs req mgr)
-        `catch` \e@(HTTP.HttpExceptionRequest _ _) -> do
-            logg Error $ "failed to submit solved work: " <> sshow e
-            return ()
+        `catch` \case
+            e@(HTTP.HttpExceptionRequest _ _) -> do
+                logg Error $ "failed to submit solved work: " <> sshow e
+                return ()
+            e -> throwIO e
   where
     logg = writeLog logger
     req = (baseReq conf ver "mining/solved")

src/JsonRpc.hs

@@ -57,12 +57,15 @@ data Static (a :: k) = Static
 
 pattern StaticNull :: Static 'Nothing
 pattern StaticNull = Static
+{-# COMPLETE StaticNull #-}
 
 pattern StaticTrue :: Static 'True
 pattern StaticTrue = Static
+{-# COMPLETE StaticTrue #-}
 
 pattern StaticFalse :: Static 'False
 pattern StaticFalse = Static
+{-# COMPLETE StaticFalse #-}
 
 instance A.ToJSON (Static 'Nothing) where
     toEncoding _ = A.null_

src/Utils.hs

@@ -311,7 +311,11 @@ le64 = f targetByteOrder
 
 -- | Encode to or from little endian. This is @id@ on little endian platforms.
 --
+#if MIN_VERSION_base(4,17,0)
+le64# :: Word64# -> Word64#
+#else
 le64# :: Word# -> Word#
+#endif
 le64# = f targetByteOrder
   where
     f BigEndian x = byteSwap64# x
@@ -333,9 +337,11 @@ secondsNs :: Integer -> Integer
 secondsNs i = i * 1_000_000_000
 {-# INLINE secondsNs #-}
 
+#if !MIN_VERSION_stm(2,5,1)
 writeTMVar :: TMVar a -> a -> STM ()
 writeTMVar var a = tryTakeTMVar var >> putTMVar var a
 {-# INLINE writeTMVar #-}
+#endif
 
 -- -------------------------------------------------------------------------- --
 -- BigNum Compatibility

src/Worker/OnDemand.hs

@@ -25,8 +25,6 @@ import Control.Concurrent.STM
 import Control.Monad
 import Control.Monad.Catch
 
-import Data.Aeson
-import qualified Data.ByteString.Lazy.Char8 as LBS8
 import Data.Function
 import Data.HashMap.Strict(HashMap)
 import qualified Data.HashMap.Strict as HashMap

src/Worker/POW/Stratum/Protocol.hs

@@ -9,6 +9,8 @@
 {-# LANGUAGE TypeApplications #-}
 {-# LANGUAGE ViewPatterns #-}
 
+{-# OPTIONS_GHC -Wno-unused-top-binds #-}
+
 -- |
 -- Module: Worker.POW.Stratum.Protocol
 -- Copyright: Copyright © 2021 Kadena LLC.
@@ -506,9 +508,10 @@ parseMiningResponse pendingRequests = A.withObject "MiningResponse" $ \o -> do
         r@Submit{} -> (r,) . SubmitResponse mid <$> parseResponse o
 
   where
-    parseSubscribeParams = A.parseJSON >=> \(StaticNull, v, s) -> case nonceSize @Int s of
-        Nothing -> fail $ "invalid nonce2 size. Expected a value between 0 and 8 but got " <> show s
-        Just ns -> (, ns) <$> parseNonce1 (complementNonceSize ns) v
+    parseSubscribeParams = A.parseJSON >=> \(StaticNull, v, s) ->
+        case nonceSize @Int s of
+            Nothing -> fail $ "invalid nonce2 size. Expected a value between 0 and 8 but got " <> show s
+            Just ns -> (, ns) <$> parseNonce1 (complementNonceSize ns) v
 
     parseAuthorizeParams = A.parseJSON >=> \(T1 StaticTrue) -> return ()
 {-# INLINE parseMiningResponse #-}

src/Worker/POW/Stratum/Server.hs

@@ -4,6 +4,8 @@
 {-# LANGUAGE ScopedTypeVariables #-}
 {-# LANGUAGE TypeApplications #-}
 
+{-# OPTIONS_GHC -Wno-unused-top-binds #-}
+
 -- |
 -- Module: Worker.POW.Stratum.Server
 -- Copyright: Copyright © 2021 Kadena LLC.
@@ -277,7 +279,7 @@ targetPeriod :: Period
 targetPeriod = Period 10
 
 notify :: Logger -> AppData -> SessionState -> Job -> IO ()
-notify logger app sessionCtx job = do
+notify logger app _sessionCtx job = do
     writeLog logger L.Info "sending notification"
     send app $ Notify (_jobId job, _jobWork job, True) -- for now we always replace previous work
 
@@ -330,7 +332,7 @@ stratumDifficultyFromText t = case readEither @Int $ T.unpack t of
 instance A.ToJSON StratumDifficulty where
   toJSON WorkDifficulty = "block"
   toJSON (DifficultyLevel i) = A.toJSON i
-  toJSON (DifficultyPeriod i) = error "ToJSON StratumDifficulty: difficulty period is currently not supported"
+  toJSON (DifficultyPeriod _i) = error "ToJSON StratumDifficulty: difficulty period is currently not supported"
 
 instance A.FromJSON StratumDifficulty where
   parseJSON v = case v of
@@ -384,7 +386,7 @@ getNewSessionTarget stratumDifficulty currentHashRate currentTarget jobTarget
         DifficultyPeriod p -> newPeriodTarget p
 
     -- The final target must be inbetween maxSessionTarget and jobTarget
-    newPeriodTarget p = max jobTarget (min maxSessionTarget candidate)
+    newPeriodTarget _p = max jobTarget (min maxSessionTarget candidate)
       where
         curD = targetToDifficulty currentTarget
         newD = adjustDifficulty periodTolerance currentHashRate targetPeriod curD