fix frontend tests

Author: Dugong42

frontend/src/components/Connect/Details/Actions/__tests__/Actions.spec.tsx

@@ -87,23 +87,25 @@ describe('Actions', () => {
       expect(screen.getByText('Resume')).toBeInTheDocument();
       expect(screen.queryByText('Pause')).not.toBeInTheDocument();
       expect(screen.queryByText('Stop')).not.toBeInTheDocument();
-      expect(screen.queryByText('Reset Offsets')).toBeInTheDocument();
-      expect(screen.getByText('Reset Offsets')).toBeDisabled();
+      await afterClickDropDownButton();
+      expect(screen.getByText('Reset Offsets')).toBeInTheDocument();
+      expect(screen.getByRole('menuitem', { name: 'Reset Offsets' })).toHaveAttribute('aria-disabled');
       expectActionButtonsExists();
     });
 
     it('renders buttons when stopped', async () => {
       (useConnector as jest.Mock).mockImplementation(() => ({
-        data: setConnectorStatus(connector, ConnectorState.PAUSED),
+        data: setConnectorStatus(connector, ConnectorState.STOPPED),
       }));
       renderComponent();
       await afterClickRestartButton();
       expect(screen.getAllByRole('menuitem').length).toEqual(4);
       expect(screen.getByText('Resume')).toBeInTheDocument();
       expect(screen.queryByText('Pause')).not.toBeInTheDocument();
       expect(screen.queryByText('Stop')).not.toBeInTheDocument();
-      expect(screen.queryByText('Reset Offsets')).toBeInTheDocument();
-      expect(screen.getByText('Reset Offsets')).toBeEnabled();
+      await afterClickDropDownButton();
+      expect(screen.getByText('Reset Offsets')).toBeInTheDocument();
+      expect(screen.getByRole('menuitem', { name: 'Reset Offsets' })).not.toHaveAttribute('aria-disabled');
       expectActionButtonsExists();
     });
 
@@ -117,8 +119,9 @@ describe('Actions', () => {
       expect(screen.queryByText('Resume')).not.toBeInTheDocument();
       expect(screen.queryByText('Pause')).not.toBeInTheDocument();
       expect(screen.queryByText('Stop')).not.toBeInTheDocument();
-      expect(screen.queryByText('Reset Offsets')).toBeInTheDocument();
-      expect(screen.getByText('Reset Offsets')).toBeDisabled();
+      await afterClickDropDownButton();
+      expect(screen.getByText('Reset Offsets')).toBeInTheDocument();
+      expect(screen.getByRole('menuitem', { name: 'Reset Offsets' })).toHaveAttribute('aria-disabled');
       expectActionButtonsExists();
     });
 
@@ -132,8 +135,9 @@ describe('Actions', () => {
       expect(screen.queryByText('Resume')).not.toBeInTheDocument();
       expect(screen.queryByText('Pause')).not.toBeInTheDocument();
       expect(screen.queryByText('Stop')).not.toBeInTheDocument();
-      expect(screen.queryByText('Reset Offsets')).toBeInTheDocument();
-      expect(screen.getByText('Reset Offsets')).toBeDisabled();
+      await afterClickDropDownButton();
+      expect(screen.getByText('Reset Offsets')).toBeInTheDocument();
+      expect(screen.getByRole('menuitem', { name: 'Reset Offsets' })).toHaveAttribute('aria-disabled');
       expectActionButtonsExists();
     });
 
@@ -143,12 +147,13 @@ describe('Actions', () => {
       }));
       renderComponent();
       await afterClickRestartButton();
-      expect(screen.getAllByRole('menuitem').length).toEqual(4);
+      expect(screen.getAllByRole('menuitem').length).toEqual(5);
       expect(screen.queryByText('Resume')).not.toBeInTheDocument();
       expect(screen.getByText('Pause')).toBeInTheDocument();
       expect(screen.getByText('Stop')).toBeInTheDocument();
-      expect(screen.queryByText('Reset Offsets')).toBeInTheDocument();
-      expect(screen.getByText('Reset Offsets')).toBeDisabled();
+      await afterClickDropDownButton();
+      expect(screen.getByText('Reset Offsets')).toBeInTheDocument();
+      expect(screen.getByRole('menuitem', { name: 'Reset Offsets' })).toHaveAttribute('aria-disabled');
       expectActionButtonsExists();
     });
 
@@ -168,7 +173,10 @@ describe('Actions', () => {
         expect(screen.getByRole('dialog')).toBeInTheDocument();
       });
 
-      it('opens confirmation modal when reset offsets button clicked', async () => {
+      it('opens confirmation modal when reset offsets button clicked on a STOPPED connector', async () => {
+        (useConnector as jest.Mock).mockImplementation(() => ({
+          data: setConnectorStatus(connector, ConnectorState.STOPPED),
+        }));
         renderComponent();
         await afterClickDropDownButton();
         await waitFor(async () =>

frontend/src/components/Connect/List/__tests__/List.spec.tsx

@@ -12,11 +12,13 @@ import { clusterConnectConnectorPath, clusterConnectorsPath } from 'lib/paths';
 import {
   useConnectors,
   useDeleteConnector,
+  useResetConnectorOffsets,
   useUpdateConnectorState,
 } from 'lib/hooks/api/kafkaConnect';
 
 const mockedUsedNavigate = jest.fn();
 const mockDelete = jest.fn();
+const mockResetOffsets = jest.fn();
 
 jest.mock('react-router-dom', () => ({
   ...jest.requireActual('react-router-dom'),
@@ -57,7 +59,7 @@ describe('Connectors List', () => {
     it('renders', async () => {
       renderComponent();
       expect(screen.getByRole('table')).toBeInTheDocument();
-      expect(screen.getAllByRole('row').length).toEqual(3);
+      expect(screen.getAllByRole('row').length).toEqual(4);
     });
 
     it('opens broker when row clicked', async () => {
@@ -129,4 +131,39 @@ describe('Connectors List', () => {
       expect(cancelButton).not.toBeInTheDocument();
     });
   });
+  
+  describe('when reset connector offsets modal is open', () => {
+    beforeEach(() => {
+      (useConnectors as jest.Mock).mockImplementation(() => ({
+        data: connectors,
+      }));
+      (useResetConnectorOffsets as jest.Mock).mockImplementation(() => ({
+        mutateAsync: mockResetOffsets,
+      }));
+    });
+
+    it('calls resetConnectorOffsets on confirm', async () => {
+      renderComponent();
+      const resetButton = screen.getAllByText('Reset Offsets')[2];
+      await waitFor(() => userEvent.click(resetButton));
+
+      const submitButton = screen.getAllByRole('button', {
+        name: 'Confirm',
+      })[0];
+      await userEvent.click(submitButton);
+      expect(mockResetOffsets).toHaveBeenCalledWith();
+    });
+
+    it('closes the modal when cancel button is clicked', async () => {
+      renderComponent();
+      const resetButton = screen.getAllByText('Reset Offsets')[2];
+      await waitFor(() => userEvent.click(resetButton));
+
+      const cancelButton = screen.getAllByRole('button', {
+        name: 'Cancel',
+      })[0];
+      await waitFor(() => userEvent.click(cancelButton));
+      expect(cancelButton).not.toBeInTheDocument();
+    });
+  });
 });

frontend/src/lib/fixtures/kafkaConnect.ts

@@ -38,6 +38,18 @@ export const connectors: FullConnectorInfo[] = [
     tasksCount: 3,
     failedTasksCount: 1,
   },
+  {
+    connect: 'third',
+    name: 'hdfs3-source-connector',
+    connectorClass: 'FileStreamSource',
+    type: ConnectorType.SINK,
+    topics: ['test-topic'],
+    status: {
+      state: ConnectorState.STOPPED,
+    },
+    tasksCount: 0,
+    failedTasksCount: 0,
+  },
 ];
 
 export const connector: Connector = {