Skip to content

Commit 1b03ebb

Browse files
authored
Merge branch 'main' into feature/refactor-maven-profiles
2 parents f469f71 + 9c028ed commit 1b03ebb

File tree

4 files changed

+15
-3
lines changed

4 files changed

+15
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ We extend our gratitude to Provectus for their past support in groundbreaking wo
5050
* **View Consumer Groups** — view per-partition parked offsets, combined and per-partition lag
5151
* **Browse Messages** — browse messages with JSON, plain text, and Avro encoding
5252
* **Dynamic Topic Configuration** — create and configure new topics with dynamic configuration
53-
* **Configurable Authentification**[secure](https://ui.docs.kafbat.io/configuration/authentication) your installation with optional Github/Gitlab/Google OAuth 2.0
53+
* **Configurable Authentication**[secure](https://ui.docs.kafbat.io/configuration/authentication) your installation with optional Github/Gitlab/Google OAuth 2.0
5454
* **Custom serialization/deserialization plugins** - [use](https://ui.docs.kafbat.io/configuration/serialization-serde) a ready-to-go serde for your data like AWS Glue or Smile, or code your own!
5555
* **Role based access control** - [manage permissions](https://ui.docs.kafbat.io/configuration/rbac-role-based-access-control) to access the UI with granular precision
5656
* **Data masking** - [obfuscate](https://ui.docs.kafbat.io/configuration/data-masking) sensitive data in topic messages

frontend/src/components/Topics/Topic/Messages/Filters/AddEditFilterContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ const AddEditFilterContainer: React.FC<AddEditFilterContainerProps> = ({
196196
</FormError>
197197
</div>
198198
<S.FilterButtonWrapper isEdit={isEdit}>
199-
{!isEdit && <QuestionInfo />}
199+
<QuestionInfo />
200200
<Flexbox gap="10px">
201201
<Button
202202
buttonSize="M"

frontend/src/components/Topics/Topic/Messages/Filters/Filters.styled.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ export const SavedFilterName = styled.div`
142142

143143
export const FilterButtonWrapper = styled.div<{ isEdit: boolean }>`
144144
display: flex;
145-
justify-content: ${(props) => (props.isEdit ? 'flex-end' : 'space-between')};
145+
justify-content: space-between;
146146
margin-top: 10px;
147147
gap: 10px;
148148
padding-top: 16px;

frontend/src/components/Topics/Topic/Messages/Filters/__tests__/AddEditFilterContainer.spec.tsx

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,12 @@ describe('AddEditFilterContainer component', () => {
7373
expect(submitButtonElem).toBeEnabled();
7474
});
7575

76+
it('should display the CEL syntax help icon', async () => {
77+
const celHelpIcon = screen.queryByLabelText('info');
78+
expect(celHelpIcon).toBeVisible();
79+
expect(celHelpIcon).toBeEnabled();
80+
});
81+
7682
// TODO needs a rethink
7783
// it('should view the error message after typing and clearing the input', async () => {
7884
// const inputs = screen.getAllByRole('textbox');
@@ -115,6 +121,12 @@ describe('AddEditFilterContainer component', () => {
115121
const checkbox = screen.queryByRole('checkbox');
116122
expect(checkbox).not.toBeInTheDocument();
117123
});
124+
125+
it('should display the CEL syntax help icon', async () => {
126+
const celHelpIcon = screen.queryByLabelText('info');
127+
expect(celHelpIcon).toBeVisible();
128+
expect(celHelpIcon).toBeEnabled();
129+
});
118130
});
119131

120132
describe('Cancel and Submit button functionality', () => {

0 commit comments

Comments
 (0)