Skip to content

Commit 26e075d

Browse files
committed
Disable reset offsets button when connector is not stopped
1 parent b819013 commit 26e075d

File tree

2 files changed

+29
-33
lines changed

2 files changed

+29
-33
lines changed

frontend/src/components/Connect/Details/Actions/Actions.tsx

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ const Actions: React.FC = () => {
108108
value: routerProps.connectName,
109109
}}
110110
>
111-
Stop Connector
111+
Stop
112112
</ActionDropdownItem>
113113
)}
114114
{(connector?.status.state === ConnectorState.PAUSED || connector?.status.state === ConnectorState.STOPPED) && (
@@ -159,20 +159,18 @@ const Actions: React.FC = () => {
159159
</ActionDropdownItem>
160160
</Dropdown>
161161
<Dropdown>
162-
{connector?.status.state === ConnectorState.STOPPED && (
163-
<ActionDropdownItem
164-
onClick={resetConnectorOffsetsHandler}
165-
disabled={isMutating}
166-
danger
167-
permission={{
168-
resource: ResourceType.CONNECT,
169-
action: Action.RESET_OFFSETS,
170-
value: routerProps.connectName,
171-
}}
172-
>
173-
Reset Connector Offsets
174-
</ActionDropdownItem>
175-
)}
162+
<ActionDropdownItem
163+
onClick={resetConnectorOffsetsHandler}
164+
disabled={isMutating || connector?.status.state !== ConnectorState.STOPPED}
165+
danger
166+
permission={{
167+
resource: ResourceType.CONNECT,
168+
action: Action.RESET_OFFSETS,
169+
value: routerProps.connectName,
170+
}}
171+
>
172+
Reset Offsets
173+
</ActionDropdownItem>
176174
<ActionDropdownItem
177175
onClick={deleteConnectorHandler}
178176
disabled={isMutating}

frontend/src/components/Connect/List/ActionsCell.tsx

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
import { CellContext } from '@tanstack/react-table';
1010
import { ClusterNameRoute } from 'lib/paths';
1111
import useAppParams from 'lib/hooks/useAppParams';
12-
import { Dropdown, DropdownItem } from 'components/common/Dropdown';
12+
import { Dropdown } from 'components/common/Dropdown';
1313
import {
1414
useDeleteConnector,
1515
useResetConnectorOffsets,
@@ -104,7 +104,7 @@ const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
104104
value: connect,
105105
}}
106106
>
107-
Pause Connector
107+
Pause
108108
</ActionDropdownItem>
109109
)}
110110
{status.state === ConnectorState.RUNNING && (
@@ -117,7 +117,7 @@ const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
117117
value: connect,
118118
}}
119119
>
120-
Stop Connector
120+
Stop
121121
</ActionDropdownItem>
122122
)}
123123
<ActionDropdownItem
@@ -153,20 +153,18 @@ const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
153153
>
154154
Restart Failed Tasks
155155
</ActionDropdownItem>
156-
{status.state === ConnectorState.STOPPED && (
157-
<ActionDropdownItem
158-
onClick={resetOffsetsHandler}
159-
disabled={isMutating}
160-
danger
161-
permission={{
162-
resource: ResourceType.CONNECT,
163-
action: Action.RESET_OFFSETS,
164-
value: connect,
165-
}}
166-
>
167-
Reset Connector Offsets
168-
</ActionDropdownItem>
169-
)}
156+
<ActionDropdownItem
157+
onClick={resetOffsetsHandler}
158+
disabled={isMutating || status.state !== ConnectorState.STOPPED}
159+
danger
160+
permission={{
161+
resource: ResourceType.CONNECT,
162+
action: Action.RESET_OFFSETS,
163+
value: connect,
164+
}}
165+
>
166+
Reset Offsets
167+
</ActionDropdownItem>
170168
<ActionDropdownItem
171169
onClick={handleDelete}
172170
danger
@@ -175,7 +173,7 @@ const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
175173
action: Action.DELETE,
176174
value: connect,
177175
}}>
178-
Remove Connector
176+
Delete
179177
</ActionDropdownItem>
180178
</Dropdown>
181179
);

0 commit comments

Comments
 (0)