Skip to content

Commit 48256a0

Browse files
authored
Merge branch 'main' into open_connectors_in_separate_tab
2 parents 8a486d2 + ac83b10 commit 48256a0

File tree

4 files changed

+29
-20
lines changed

4 files changed

+29
-20
lines changed

.github/dependabot.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,15 @@ updates:
1212
- "type/dependencies"
1313
- "scope/backend"
1414
groups:
15-
gradle-dependencies:
15+
spring-boot-dependencies:
16+
patterns:
17+
- "org.springframework.boot:*"
18+
- "io.spring.dependency-management"
19+
# We will handle major upgrades manually
20+
update-types:
21+
- "patch"
22+
- "minor"
23+
other-dependencies:
1624
patterns:
1725
- "*"
1826
update-types:

frontend/src/components/Brokers/Broker/Configs/TableComponents/InputCell/InputCellViewMode.tsx

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import React, { type FC } from 'react';
2-
import { Button } from 'components/common/Button/Button';
32
import EditIcon from 'components/common/Icons/EditIcon';
43
import type { ConfigUnit } from 'components/Brokers/Broker/Configs/lib/types';
5-
import Tooltip from 'components/common/Tooltip/Tooltip';
64
import { getConfigDisplayValue } from 'components/Brokers/Broker/Configs/lib/utils';
5+
import { ActionButton } from 'components/common/ActionComponent';
6+
import { Action, ResourceType } from 'generated-sources';
7+
import { getDefaultActionMessage } from 'components/common/ActionComponent/ActionComponent';
78

89
import * as S from './styled';
910

@@ -35,22 +36,22 @@ const InputCellViewMode: FC<InputCellViewModeProps> = ({
3536
<S.Value $isDynamic={isDynamic} title={title}>
3637
{displayValue}
3738
</S.Value>
38-
<Tooltip
39-
value={
40-
<Button
41-
buttonType="primary"
42-
buttonSize="S"
43-
aria-label="editAction"
44-
onClick={onEdit}
45-
disabled={isReadOnly}
46-
>
47-
<EditIcon /> Edit
48-
</Button>
39+
<ActionButton
40+
buttonType="primary"
41+
buttonSize="S"
42+
aria-label="editAction"
43+
onClick={onEdit}
44+
disabled={isReadOnly}
45+
message={
46+
isReadOnly ? 'Property is read-only' : getDefaultActionMessage()
4947
}
50-
showTooltip={isReadOnly}
51-
content="Property is read-only"
52-
placement="left"
53-
/>
48+
permission={{
49+
resource: ResourceType.CLUSTERCONFIG,
50+
action: Action.EDIT,
51+
}}
52+
>
53+
<EditIcon /> Edit
54+
</ActionButton>
5455
</S.ValueWrapper>
5556
);
5657
};

frontend/src/components/common/ActionComponent/ActionButton/ActionCanButton/ActionCanButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const ActionButton: React.FC<Props> = ({
2121
const isDisabled = !canDoAction;
2222

2323
const { x, y, refs, strategy, open } = useActionTooltip(
24-
isDisabled,
24+
isDisabled || disabled,
2525
placement
2626
);
2727

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ checkstyle = '10.24.0'
3838
allure = '2.29.1'
3939
selenide = '7.2.3'
4040
testng = '7.10.0'
41-
bonigarcia-webdrivermanager = '5.9.3'
41+
bonigarcia-webdrivermanager = '6.1.1'
4242
aspectj = '1.9.21'
4343

4444
[plugins]

0 commit comments

Comments
 (0)