Skip to content

Commit 68a8a26

Browse files
committed
Reduced duplicate code
1 parent 40760ca commit 68a8a26

File tree

3 files changed

+30
-48
lines changed

3 files changed

+30
-48
lines changed

api/src/main/java/io/kafbat/ui/serdes/builtin/ConsumerOffsetsSerde.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -48,31 +48,11 @@ public static String name() {
4848
return "__consumer_offsets";
4949
}
5050

51-
@Override
52-
public Optional<String> getDescription() {
53-
return Optional.empty();
54-
}
55-
56-
@Override
57-
public Optional<SchemaDescription> getSchema(String topic, Target type) {
58-
return Optional.empty();
59-
}
60-
6151
@Override
6252
public boolean canDeserialize(String topic, Target type) {
6353
return topic.equals(TOPIC);
6454
}
6555

66-
@Override
67-
public boolean canSerialize(String topic, Target type) {
68-
return false;
69-
}
70-
71-
@Override
72-
public Serializer serializer(String topic, Target type) {
73-
throw new UnsupportedOperationException();
74-
}
75-
7656
@Override
7757
public Deserializer deserializer(String topic, Target type) {
7858
return switch (type) {

api/src/main/java/io/kafbat/ui/serdes/builtin/StructSerde.java

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,16 @@
55
import com.fasterxml.jackson.databind.SerializerProvider;
66
import com.fasterxml.jackson.databind.json.JsonMapper;
77
import com.fasterxml.jackson.databind.module.SimpleModule;
8+
import io.kafbat.ui.serde.api.SchemaDescription;
9+
import io.kafbat.ui.serde.api.Serde;
10+
import io.kafbat.ui.serdes.BuiltInSerde;
811
import java.io.IOException;
12+
import java.util.Optional;
913
import lombok.SneakyThrows;
1014
import org.apache.kafka.common.protocol.types.BoundField;
1115
import org.apache.kafka.common.protocol.types.Struct;
1216

13-
public abstract class StructSerde {
17+
public abstract class StructSerde implements BuiltInSerde {
1418

1519
private static final JsonMapper JSON_MAPPER = createMapper();
1620

@@ -32,6 +36,31 @@ public void serialize(Struct value, JsonGenerator gen, SerializerProvider serial
3236
return mapper;
3337
}
3438

39+
@Override
40+
public Optional<String> getDescription() {
41+
return Optional.empty();
42+
}
43+
44+
@Override
45+
public Optional<SchemaDescription> getSchema(String topic, Serde.Target type) {
46+
return Optional.empty();
47+
}
48+
49+
@Override
50+
public boolean canDeserialize(String topic, Serde.Target type) {
51+
return true;
52+
}
53+
54+
@Override
55+
public boolean canSerialize(String topic, Serde.Target type) {
56+
return false;
57+
}
58+
59+
@Override
60+
public Serde.Serializer serializer(String topic, Serde.Target type) {
61+
throw new UnsupportedOperationException();
62+
}
63+
3564
@SneakyThrows
3665
protected String toJson(Struct s) {
3766
return JSON_MAPPER.writeValueAsString(s);

api/src/main/java/io/kafbat/ui/serdes/builtin/mm2/MirrorMakerSerde.java

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package io.kafbat.ui.serdes.builtin.mm2;
22

33
import io.kafbat.ui.serde.api.DeserializeResult;
4-
import io.kafbat.ui.serde.api.SchemaDescription;
5-
import io.kafbat.ui.serde.api.Serde;
64
import io.kafbat.ui.serdes.BuiltInSerde;
75
import io.kafbat.ui.serdes.builtin.StructSerde;
86
import java.nio.ByteBuffer;
@@ -17,31 +15,6 @@ abstract class MirrorMakerSerde extends StructSerde implements BuiltInSerde {
1715

1816
protected final boolean versioned;
1917

20-
@Override
21-
public Optional<String> getDescription() {
22-
return Optional.empty();
23-
}
24-
25-
@Override
26-
public Optional<SchemaDescription> getSchema(String topic, Serde.Target type) {
27-
return Optional.empty();
28-
}
29-
30-
@Override
31-
public boolean canDeserialize(String topic, Serde.Target type) {
32-
return true;
33-
}
34-
35-
@Override
36-
public boolean canSerialize(String topic, Serde.Target type) {
37-
return false;
38-
}
39-
40-
@Override
41-
public Serde.Serializer serializer(String topic, Serde.Target type) {
42-
throw new UnsupportedOperationException();
43-
}
44-
4518
@Override
4619
public Deserializer deserializer(String topic, Target target) {
4720
return (recordHeaders, bytes) ->

0 commit comments

Comments
 (0)