Reduced duplicate code

Author: germanosin

api/src/main/java/io/kafbat/ui/serdes/BuiltInSerde.java

@@ -1,7 +1,9 @@
 package io.kafbat.ui.serdes;
 
 import io.kafbat.ui.serde.api.PropertyResolver;
+import io.kafbat.ui.serde.api.SchemaDescription;
 import io.kafbat.ui.serde.api.Serde;
+import java.util.Optional;
 
 public interface BuiltInSerde extends Serde {
 
@@ -24,4 +26,25 @@ default void configure(PropertyResolver serdeProperties,
                          PropertyResolver kafkaClusterProperties,
                          PropertyResolver globalProperties) {
   }
+
+  @Override
+  default boolean canSerialize(String topic, Serde.Target type) {
+    return false;
+  }
+
+  @Override
+  default Serde.Serializer serializer(String topic, Serde.Target type) {
+    throw new UnsupportedOperationException();
+  }
+
+  @Override
+  default Optional<SchemaDescription> getSchema(String topic, Serde.Target type) {
+    return Optional.empty();
+  }
+
+  @Override
+  default Optional<String> getDescription() {
+    return Optional.empty();
+  }
+
 }

api/src/main/java/io/kafbat/ui/serdes/SerdesInitializer.java

@@ -150,13 +150,13 @@ public ClusterSerdes init(Environment env,
    * Registers serdse that should only be used for specific (hard-coded) topics, like ConsumerOffsetsSerde.
    */
   private void registerTopicRelatedSerde(Map<String, SerdeInstance> serdes) {
-    registerConsumerOffsetsSerde(serdes);
-    registerMirrorMakerSerdes(serdes);
+    serdes.putAll(consumerOffsetsSerde(serdes));
+    serdes.putAll(mirrorMakerSerdes(serdes));
   }
 
-  private void registerConsumerOffsetsSerde(Map<String, SerdeInstance> serdes) {
+  private Map<String, SerdeInstance> consumerOffsetsSerde(Map<String, SerdeInstance> serdes) {
     var pattern = Pattern.compile(ConsumerOffsetsSerde.TOPIC);
-    serdes.put(
+    return Map.of(
         ConsumerOffsetsSerde.name(),
         new SerdeInstance(
             ConsumerOffsetsSerde.name(),
@@ -168,22 +168,19 @@ private void registerConsumerOffsetsSerde(Map<String, SerdeInstance> serdes) {
     );
   }
 
-  private void registerMirrorMakerSerdes(Map<String, SerdeInstance> serdes) {
-    Map<String,Map.Entry<Pattern, BuiltInSerde>> mmSerdes = Map.of(
-        HeartbeatSerde.name(), Map.entry(HeartbeatSerde.TOPIC_NAME_PATTERN, new HeartbeatSerde()),
-        OffsetSyncSerde.name(), Map.entry(OffsetSyncSerde.TOPIC_NAME_PATTERN, new OffsetSyncSerde()),
-        CheckpointSerde.name(), Map.entry(CheckpointSerde.TOPIC_NAME_PATTERN, new CheckpointSerde())
+  private Map<String, SerdeInstance> mirrorMakerSerdes(Map<String, SerdeInstance> serdes) {
+    return Map.of(
+        HeartbeatSerde.name(),
+        mirrorSerde(HeartbeatSerde.name(), HeartbeatSerde.TOPIC_NAME_PATTERN, new HeartbeatSerde()),
+        OffsetSyncSerde.name(),
+        mirrorSerde(HeartbeatSerde.name(), OffsetSyncSerde.TOPIC_NAME_PATTERN, new OffsetSyncSerde()),
+        CheckpointSerde.name(),
+        mirrorSerde(HeartbeatSerde.name(), CheckpointSerde.TOPIC_NAME_PATTERN, new CheckpointSerde())
     );
-    for (Map.Entry<String, Map.Entry<Pattern, BuiltInSerde>> serde : mmSerdes.entrySet()) {
-      String name = serde.getKey();
-      Pattern pattern = serde.getValue().getKey();
-      BuiltInSerde serdeInstance = serde.getValue().getValue();
+  }
 
-      serdes.put(
-          name,
-          new SerdeInstance(name, serdeInstance, pattern, pattern, null)
-      );
-    }
+  private SerdeInstance mirrorSerde(String name, Pattern pattern, BuiltInSerde serde) {
+    return new SerdeInstance(name, serde, pattern, pattern, null);
   }
 
   private SerdeInstance createFallbackSerde() {

api/src/main/java/io/kafbat/ui/serdes/builtin/AvroEmbeddedSerde.java

@@ -18,26 +18,11 @@ public static String name() {
     return "Avro (Embedded)";
   }
 
-  @Override
-  public Optional<String> getDescription() {
-    return Optional.empty();
-  }
-
-  @Override
-  public Optional<SchemaDescription> getSchema(String topic, Target type) {
-    return Optional.empty();
-  }
-
   @Override
   public boolean canDeserialize(String topic, Target type) {
     return true;
   }
 
-  @Override
-  public boolean canSerialize(String topic, Target type) {
-    return false;
-  }
-
   @Override
   public Serializer serializer(String topic, Target type) {
     throw new IllegalStateException();

api/src/main/java/io/kafbat/ui/serdes/builtin/Base64Serde.java

@@ -14,16 +14,6 @@ public static String name() {
     return "Base64";
   }
 
-  @Override
-  public Optional<String> getDescription() {
-    return Optional.empty();
-  }
-
-  @Override
-  public Optional<SchemaDescription> getSchema(String topic, Serde.Target type) {
-    return Optional.empty();
-  }
-
   @Override
   public boolean canDeserialize(String topic, Serde.Target type) {
     return true;

api/src/main/java/io/kafbat/ui/serdes/builtin/HexSerde.java

@@ -37,16 +37,6 @@ private void configure(String delim, boolean uppercase) {
     }
   }
 
-  @Override
-  public Optional<String> getDescription() {
-    return Optional.empty();
-  }
-
-  @Override
-  public Optional<SchemaDescription> getSchema(String topic, Target type) {
-    return Optional.empty();
-  }
-
   @Override
   public boolean canDeserialize(String topic, Target type) {
     return true;

api/src/main/java/io/kafbat/ui/serdes/builtin/Int32Serde.java

@@ -13,11 +13,6 @@ public static String name() {
     return "Int32";
   }
 
-  @Override
-  public Optional<String> getDescription() {
-    return Optional.empty();
-  }
-
   @Override
   public Optional<SchemaDescription> getSchema(String topic, Target type) {
     return Optional.of(

api/src/main/java/io/kafbat/ui/serdes/builtin/Int64Serde.java

@@ -14,11 +14,6 @@ public static String name() {
     return "Int64";
   }
 
-  @Override
-  public Optional<String> getDescription() {
-    return Optional.empty();
-  }
-
   @Override
   public Optional<SchemaDescription> getSchema(String topic, Serde.Target type) {
     return Optional.of(

api/src/main/java/io/kafbat/ui/serdes/builtin/ProtobufFileSerde.java

@@ -121,11 +121,6 @@ void configure(Configuration configuration) {
     this.keyMessageDescriptorMap = configuration.keyMessageDescriptorMap();
   }
 
-  @Override
-  public Optional<String> getDescription() {
-    return Optional.empty();
-  }
-
   private Optional<Descriptor> descriptorFor(String topic, Serde.Target type) {
     return type == Serde.Target.KEY
         ?

api/src/main/java/io/kafbat/ui/serdes/builtin/ProtobufRawSerde.java

@@ -17,31 +17,12 @@ public static String name() {
     return "ProtobufDecodeRaw";
   }
 
-  @Override
-  public Optional<String> getDescription() {
-    return Optional.empty();
-  }
-
-  @Override
-  public Optional<SchemaDescription> getSchema(String topic, Serde.Target type) {
-    return Optional.empty();
-  }
-
-  @Override
-  public boolean canSerialize(String topic, Serde.Target type) {
-    return false;
-  }
 
   @Override
   public boolean canDeserialize(String topic, Serde.Target type) {
     return true;
   }
 
-  @Override
-  public Serde.Serializer serializer(String topic, Serde.Target type) {
-    throw new UnsupportedOperationException();
-  }
-
   @Override
   public Serde.Deserializer deserializer(String topic, Serde.Target type) {
     return new Serde.Deserializer() {

api/src/main/java/io/kafbat/ui/serdes/builtin/StringSerde.java

@@ -26,16 +26,6 @@ public void configure(PropertyResolver serdeProperties,
         .ifPresent(e -> StringSerde.this.encoding = e);
   }
 
-  @Override
-  public Optional<String> getDescription() {
-    return Optional.empty();
-  }
-
-  @Override
-  public Optional<SchemaDescription> getSchema(String topic, Target type) {
-    return Optional.empty();
-  }
-
   @Override
   public boolean canDeserialize(String topic, Target type) {
     return true;