BE: Fix NPE when parsing broker versions (#1242)

germanosin · web-flow · commit 82042f9935d7 · 2025-08-05T18:00:55.000+05:00
diff --git a/api/src/main/java/io/kafbat/ui/service/ReactiveAdminClient.java b/api/src/main/java/io/kafbat/ui/service/ReactiveAdminClient.java
@@ -163,9 +163,9 @@ private static Mono<ConfigRelatedInfo> extract(AdminClient ac) {
                   boolean topicDeletionEnabled = true;
                   for (ConfigEntry entry : configs) {
                     if (entry.name().contains("inter.broker.protocol.version")) {
-                      version = Optional.of(entry.value());
+                      version = Optional.ofNullable(entry.value());
                     }
-                    if (entry.name().equals("delete.topic.enable")) {
+                    if (entry.name().equals("delete.topic.enable") && entry.value() != null) {
                       topicDeletionEnabled = Boolean.parseBoolean(entry.value());
                     }
                   }

Original file line number	Diff line number	Diff line change
`@@ -163,9 +163,9 @@ private static Mono<ConfigRelatedInfo> extract(AdminClient ac) {`
`163`	`163`	`boolean topicDeletionEnabled = true;`
`164`	`164`	`for (ConfigEntry entry : configs) {`
`165`	`165`	`if (entry.name().contains("inter.broker.protocol.version")) {`
`166`		`- version = Optional.of(entry.value());`
	`166`	`+ version = Optional.ofNullable(entry.value());`
`167`	`167`	`}`
`168`		`- if (entry.name().equals("delete.topic.enable")) {`
	`168`	`+ if (entry.name().equals("delete.topic.enable") && entry.value() != null) {`
`169`	`169`	`topicDeletionEnabled = Boolean.parseBoolean(entry.value());`
`170`	`170`	`}`
`171`	`171`	`}`