Skip to content

Commit 849aa1c

Browse files
authored
Merge branch 'main' into feat/button-state-in-ro-mode
2 parents 0fb3841 + b4ffd96 commit 849aa1c

File tree

12 files changed

+199
-177
lines changed

12 files changed

+199
-177
lines changed

api/pom.xml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -266,18 +266,6 @@
266266
<artifactId>cel</artifactId>
267267
</dependency>
268268
<!-- CVE fixes -->
269-
<dependency>
270-
<groupId>ch.qos.logback</groupId>
271-
<artifactId>logback-classic</artifactId>
272-
<version>1.4.12</version>
273-
</dependency>
274-
<!-- CVE fixes -->
275-
<dependency>
276-
<groupId>ch.qos.logback</groupId>
277-
<artifactId>logback-core</artifactId>
278-
<version>1.4.12</version>
279-
</dependency>
280-
<!-- CVE fixes -->
281269
<dependency>
282270
<groupId>com.squareup.okhttp3</groupId>
283271
<artifactId>logging-interceptor</artifactId>
@@ -289,7 +277,6 @@
289277
<artifactId>commons-compress</artifactId>
290278
<version>1.26.0</version>
291279
</dependency>
292-
293280
</dependencies>
294281

295282
<build>

api/src/main/java/io/kafbat/ui/config/ReadOnlyModeFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public class ReadOnlyModeFilter implements WebFilter {
2525
Pattern.compile("/api/clusters/(?<clusterName>[^/]++)");
2626

2727
private static final Set<Pattern> SAFE_ENDPOINTS = Set.of(
28-
Pattern.compile("/api/clusters/[^/]+/topics/[^/]+/(smartfilters)$")
28+
Pattern.compile("/api/clusters/[^/]+/topics/[^/]+/(smartfilters|analysis)$")
2929
);
3030

3131
private final ClustersStorage clustersStorage;

api/src/main/java/io/kafbat/ui/model/InternalBrokerConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ public class InternalBrokerConfig {
1616
private final boolean isReadOnly;
1717
private final List<ConfigEntry.ConfigSynonym> synonyms;
1818

19-
public static InternalBrokerConfig from(ConfigEntry configEntry) {
19+
public static InternalBrokerConfig from(ConfigEntry configEntry, boolean readOnlyCluster) {
2020
InternalBrokerConfig.InternalBrokerConfigBuilder builder = InternalBrokerConfig.builder()
2121
.name(configEntry.name())
2222
.value(configEntry.value())
2323
.source(configEntry.source())
24-
.isReadOnly(configEntry.isReadOnly())
24+
.isReadOnly(readOnlyCluster || configEntry.isReadOnly())
2525
.isSensitive(configEntry.isSensitive())
2626
.synonyms(configEntry.synonyms());
2727
return builder.build();

api/src/main/java/io/kafbat/ui/service/BrokerService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ private Flux<InternalBrokerConfig> getBrokersConfig(KafkaCluster cluster, Intege
5959
}
6060
return loadBrokersConfig(cluster, brokerId)
6161
.map(list -> list.stream()
62-
.map(InternalBrokerConfig::from)
62+
.map(configEntry -> InternalBrokerConfig.from(configEntry, cluster.isReadOnly()))
6363
.collect(Collectors.toList()))
6464
.flatMapMany(Flux::fromIterable);
6565
}

api/src/test/java/io/kafbat/ui/serdes/PropertyResolverImplTest.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
import java.util.List;
77
import java.util.Map;
8-
import lombok.AllArgsConstructor;
9-
import lombok.Data;
108
import org.junit.jupiter.api.Nested;
119
import org.junit.jupiter.api.Test;
1210
import org.springframework.boot.context.properties.bind.BindException;
@@ -21,11 +19,7 @@ class PropertyResolverImplTest {
2119

2220
private final MockEnvironment env = new MockEnvironment();
2321

24-
@Data
25-
@AllArgsConstructor
26-
public static class CustomPropertiesClass {
27-
private String f1;
28-
private Integer f2;
22+
public record CustomPropertiesClass(String f1, Integer f2) {
2923
}
3024

3125
@Test

api/src/test/java/io/kafbat/ui/service/ksql/KsqlApiClientTest.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@
33
import static org.assertj.core.api.Assertions.assertThat;
44

55
import com.fasterxml.jackson.databind.node.ArrayNode;
6-
import com.fasterxml.jackson.databind.node.DecimalNode;
6+
import com.fasterxml.jackson.databind.node.DoubleNode;
77
import com.fasterxml.jackson.databind.node.IntNode;
88
import com.fasterxml.jackson.databind.node.JsonNodeFactory;
99
import com.fasterxml.jackson.databind.node.TextNode;
1010
import io.kafbat.ui.AbstractIntegrationTest;
11-
import java.math.BigDecimal;
1211
import java.time.Duration;
1312
import java.util.Map;
1413
import org.junit.jupiter.api.AfterAll;
@@ -80,23 +79,23 @@ private void assertLastKsqTutorialQueryResult(KsqlApiClient client) {
8079
assertThat(header.getValues()).isNull();
8180
})
8281
.assertNext(row -> {
83-
var distance = (DecimalNode) row.getValues().get(0).get(0);
82+
var distance = (DoubleNode) row.getValues().get(0).get(0);
8483
var riders = (ArrayNode) row.getValues().get(0).get(1);
8584
var count = (IntNode) row.getValues().get(0).get(2);
8685

87-
assertThat(distance).isEqualTo(new DecimalNode(new BigDecimal(0)));
86+
assertThat(distance).isEqualTo(new DoubleNode(0D));
8887
assertThat(riders).isEqualTo(new ArrayNode(JsonNodeFactory.instance)
8988
.add(new TextNode("4ab5cbad"))
9089
.add(new TextNode("8b6eae59"))
9190
.add(new TextNode("4a7c7b41")));
9291
assertThat(count).isEqualTo(new IntNode(3));
9392
})
9493
.assertNext(row -> {
95-
var distance = (DecimalNode) row.getValues().get(0).get(0);
94+
var distance = (DoubleNode) row.getValues().get(0).get(0);
9695
var riders = (ArrayNode) row.getValues().get(0).get(1);
9796
var count = (IntNode) row.getValues().get(0).get(2);
9897

99-
assertThat(distance).isEqualTo(new DecimalNode(new BigDecimal(10)));
98+
assertThat(distance).isEqualTo(new DoubleNode(10D));
10099
assertThat(riders).isEqualTo(new ArrayNode(JsonNodeFactory.instance)
101100
.add(new TextNode("18f4ea86")));
102101
assertThat(count).isEqualTo(new IntNode(1));

frontend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"pretty-ms": "7.0.1",
2222
"react": "18.2.0",
2323
"react-ace": "11.0.1",
24-
"react-datepicker": "6.9.0",
24+
"react-datepicker": "7.4.0",
2525
"react-dom": "18.2.0",
2626
"react-error-boundary": "4.0.13",
2727
"react-hook-form": "7.51.3",

0 commit comments

Comments
 (0)