Skip to content

Commit 94f3640

Browse files
author
Leshe4ka
committed
Merge branch 'main' of github.com:kafbat/kafka-ui into kafbat/203
2 parents dd93106 + 5d7cc23 commit 94f3640

File tree

7 files changed

+34
-29
lines changed

7 files changed

+34
-29
lines changed

documentation/compose/kafbat-ui.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,18 @@ services:
6262
- "9093:9092"
6363
- "9998:9998"
6464
environment:
65-
KAFKA_BROKER_ID: 1
65+
KAFKA_BROKER_ID: 2
6666
KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: 'CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT'
6767
KAFKA_ADVERTISED_LISTENERS: 'PLAINTEXT://kafka1:29092,PLAINTEXT_HOST://localhost:9092'
6868
KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
6969
KAFKA_GROUP_INITIAL_REBALANCE_DELAY_MS: 0
7070
KAFKA_TRANSACTION_STATE_LOG_MIN_ISR: 1
7171
KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR: 1
7272
KAFKA_JMX_PORT: 9998
73-
KAFKA_JMX_OPTS: -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=kafka0 -Dcom.sun.management.jmxremote.rmi.port=9998
73+
KAFKA_JMX_OPTS: -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=kafka1 -Dcom.sun.management.jmxremote.rmi.port=9998
7474
KAFKA_PROCESS_ROLES: 'broker,controller'
75-
KAFKA_NODE_ID: 1
76-
KAFKA_CONTROLLER_QUORUM_VOTERS: '1@kafka1:29093'
75+
KAFKA_NODE_ID: 2
76+
KAFKA_CONTROLLER_QUORUM_VOTERS: '2@kafka1:29093'
7777
KAFKA_LISTENERS: 'PLAINTEXT://kafka1:29092,CONTROLLER://kafka1:29093,PLAINTEXT_HOST://0.0.0.0:9092'
7878
KAFKA_INTER_BROKER_LISTENER_NAME: 'PLAINTEXT'
7979
KAFKA_CONTROLLER_LISTENER_NAMES: 'CONTROLLER'

frontend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"react-hot-toast": "2.4.1",
2929
"react-is": "18.2.0",
3030
"react-multi-select-component": "4.3.4",
31-
"react-router-dom": "6.4.3",
31+
"react-router-dom": "6.23.0",
3232
"sass": "1.66.1",
3333
"styled-components": "6.1.8",
3434
"use-debounce": "10.0.0",

frontend/pnpm-lock.yaml

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/src/components/Topics/shared/Form/TopicForm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ const TopicForm: React.FC<Props> = ({
206206
id="topicFormRetentionBytesLabel"
207207
htmlFor="topicFormRetentionBytes"
208208
>
209-
Max size on disk in GB
209+
Max partition size in GB
210210
</InputLabel>
211211
<Controller
212212
control={control}

frontend/src/components/Topics/shared/Form/__tests__/TopicForm.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ describe('TopicForm', () => {
5252
expectByRoleAndNameToBeInDocument('button', '7 days');
5353
expectByRoleAndNameToBeInDocument('button', '4 weeks');
5454

55-
expectByRoleAndNameToBeInDocument('listbox', 'Max size on disk in GB');
55+
expectByRoleAndNameToBeInDocument('listbox', 'Max partition size in GB');
5656
expectByRoleAndNameToBeInDocument(
5757
'spinbutton',
5858
'Maximum message size in bytes'

frontend/src/lib/hooks/api/topicMessages.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,10 @@ export const useTopicMessages = ({
9494
default:
9595
}
9696

97-
searchParams.getAll(MessagesFilterKeys.partitions).forEach((value) => {
98-
requestParams.append(MessagesFilterKeys.partitions, value);
99-
});
100-
97+
const partitions = searchParams.get(MessagesFilterKeys.partitions);
98+
if (partitions !== null) {
99+
requestParams.append(MessagesFilterKeys.partitions, partitions);
100+
}
101101
const { nextCursor, setNextCursor } = useMessageFiltersStore.getState();
102102

103103
const tempCompareUrl = new URLSearchParams(requestParams);

frontend/src/lib/hooks/useMessagesFilters.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,9 @@ export function useMessagesFilters() {
9292

9393
const search = searchParams.get(MessagesFilterKeys.stringFilter) || '';
9494

95-
const partitions = searchParams.getAll(MessagesFilterKeys.partitions);
95+
const partitions = (searchParams.get(MessagesFilterKeys.partitions) || '')
96+
.split(',')
97+
.filter((v) => v);
9698

9799
const smartFilterId =
98100
searchParams.get(MessagesFilterKeys.activeFilterId) ||
@@ -166,9 +168,12 @@ export function useMessagesFilters() {
166168
setSearchParams((params) => {
167169
params.delete(MessagesFilterKeys.partitions);
168170

169-
values.forEach((option) => {
170-
params.append(MessagesFilterKeys.partitions, option.value);
171-
});
171+
if (values.length) {
172+
params.append(
173+
MessagesFilterKeys.partitions,
174+
values.map((v) => v.value).join(',')
175+
);
176+
}
172177

173178
return params;
174179
});

0 commit comments

Comments
 (0)