Skip to content

Commit 9ea7766

Browse files
committed
FE: Remove redundant connectors request
1 parent 6f5b2ca commit 9ea7766

File tree

3 files changed

+12
-16
lines changed

3 files changed

+12
-16
lines changed

frontend/src/components/Connect/List/List.tsx

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
11
import React from 'react';
2-
import useAppParams from 'lib/hooks/useAppParams';
3-
import { ClusterNameRoute } from 'lib/paths';
42
import Table, { TagCell } from 'components/common/NewTable';
53
import { FullConnectorInfo } from 'generated-sources';
6-
import { useConnectors } from 'lib/hooks/api/kafkaConnect';
74
import { ColumnDef } from '@tanstack/react-table';
8-
import { useSearchParams } from 'react-router-dom';
95
import { useQueryPersister } from 'components/common/NewTable/ColumnFilter';
106
import { useLocalStoragePersister } from 'components/common/NewTable/ColumnResizer/lib';
117
import BreakableTextCell from 'components/common/NewTable/BreakableTextCell';
12-
import useFts from 'components/common/Fts/useFts';
138

149
import ActionsCell from './ActionsCell';
1510
import TopicsCell from './TopicsCell';
@@ -78,16 +73,9 @@ const kafkaConnectColumns: ColumnDef<FullConnectorInfo, string>[] = [
7873
},
7974
];
8075

81-
const List: React.FC = () => {
82-
const { clusterName } = useAppParams<ClusterNameRoute>();
83-
const [searchParams] = useSearchParams();
84-
const { isFtsEnabled } = useFts('connects');
85-
const { data: connectors } = useConnectors(
86-
clusterName,
87-
searchParams.get('q') || '',
88-
isFtsEnabled
89-
);
76+
type ConnectorsListProps = { connectors: FullConnectorInfo[] | undefined };
9077

78+
const List: React.FC<ConnectorsListProps> = ({ connectors }) => {
9179
const filterPersister = useQueryPersister(kafkaConnectColumns);
9280
const columnSizingPersister = useLocalStoragePersister('KafkaConnect');
9381

frontend/src/components/Connect/List/ListPage.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import PageLoader from 'components/common/PageLoader/PageLoader';
66
import { useConnectors } from 'lib/hooks/api/kafkaConnect';
77
import Fts from 'components/common/Fts/Fts';
88
import useFts from 'components/common/Fts/useFts';
9+
import { useSearchParams } from 'react-router-dom';
910

1011
import * as S from './ListPage.styled';
1112
import List from './List';
@@ -14,7 +15,13 @@ import ConnectorsStatistics from './Statistics/Statistics';
1415
const ListPage: React.FC = () => {
1516
useFts('connects');
1617
const { clusterName } = useAppParams<ClusterNameRoute>();
17-
const { data, isLoading } = useConnectors(clusterName);
18+
const { isFtsEnabled } = useFts('connects');
19+
const [searchParams] = useSearchParams();
20+
const { data, isLoading } = useConnectors(
21+
clusterName,
22+
searchParams.get('q') || '',
23+
isFtsEnabled
24+
);
1825

1926
return (
2027
<>
@@ -26,7 +33,7 @@ const ListPage: React.FC = () => {
2633
/>
2734
</S.Search>
2835
<Suspense fallback={<PageLoader />}>
29-
<List />
36+
<List connectors={data ?? []} />
3037
</Suspense>
3138
</>
3239
);

frontend/src/lib/hooks/api/kafkaConnect.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ export function useConnectors(
6363
connectorsKey(clusterName, search, fts),
6464
() => api.getAllConnectors({ clusterName, search, fts }),
6565
{
66+
keepPreviousData: true,
6667
select: (data) =>
6768
[...data].sort((a, b) => {
6869
if (a.name < b.name) {

0 commit comments

Comments
 (0)