Skip to content

Commit b52f5b9

Browse files
committed
Fixed tests errors
1 parent 431cb74 commit b52f5b9

File tree

4 files changed

+10
-17
lines changed

4 files changed

+10
-17
lines changed

frontend/src/components/Connect/List/__tests__/ListPage.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ describe('Connectors List Page', () => {
4949
it('renders header without create button for readonly cluster', async () => {
5050
await renderComponent({ ...initialValue, isReadOnly: true });
5151
expect(
52-
screen.getByRole('heading', { name: 'Connectors' })
52+
screen.getByRole('heading', { name: /local \/ Connectors/ })
5353
).toBeInTheDocument();
5454
expect(
5555
screen.queryByRole('link', { name: 'Create Connector' })
@@ -59,7 +59,7 @@ describe('Connectors List Page', () => {
5959
it('renders header with create button for read/write cluster', async () => {
6060
await renderComponent();
6161
expect(
62-
screen.getByRole('heading', { name: 'Connectors' })
62+
screen.getByRole('heading', { name: /local \/ Connectors/ })
6363
).toBeInTheDocument();
6464
expect(
6565
screen.getByRole('link', { name: 'Create Connector' })

frontend/src/components/Nav/ClusterMenu/__tests__/ClusterMenu.spec.tsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import React from 'react';
22
import { screen } from '@testing-library/react';
33
import { Cluster, ClusterFeaturesEnum } from 'generated-sources';
44
import ClusterMenu from 'components/Nav/ClusterMenu/ClusterMenu';
5-
import userEvent from '@testing-library/user-event';
65
import { clusterConnectorsPath } from 'lib/paths';
76
import { render } from 'lib/testHelpers';
87
import { onlineClusterPayload } from 'lib/fixtures/clusters';
@@ -31,8 +30,6 @@ describe('ClusterMenu', () => {
3130
render(setupComponent(onlineClusterPayload));
3231
expect(getCluster()).toBeInTheDocument();
3332

34-
expect(getMenuItems().length).toEqual(1);
35-
await userEvent.click(getMenuItem());
3633
expect(getMenuItems().length).toEqual(4);
3734

3835
expect(getBrokers()).toBeInTheDocument();
@@ -50,8 +47,6 @@ describe('ClusterMenu', () => {
5047
],
5148
})
5249
);
53-
expect(getMenuItems().length).toEqual(1);
54-
await userEvent.click(getMenuItem());
5550
expect(getMenuItems().length).toEqual(7);
5651

5752
expect(getBrokers()).toBeInTheDocument();
@@ -80,8 +75,6 @@ describe('ClusterMenu', () => {
8075
}),
8176
{ initialEntries: [clusterConnectorsPath(onlineClusterPayload.name)] }
8277
);
83-
expect(getMenuItems().length).toEqual(1);
84-
await userEvent.click(getMenuItem());
8578
expect(getMenuItems().length).toEqual(5);
8679

8780
const kafkaConnect = getKafkaConnect();

frontend/src/components/Nav/__tests__/Nav.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ describe('Nav', () => {
3434

3535
it('renders ClusterMenu', () => {
3636
renderComponent([onlineClusterPayload, offlineClusterPayload]);
37-
expect(screen.getAllByRole('menu').length).toEqual(3);
38-
expect(getMenuItemsCount()).toEqual(3);
37+
expect(screen.getAllByRole('menu').length).toEqual(5);
38+
expect(getMenuItemsCount()).toEqual(9);
3939
expect(getDashboard()).toBeInTheDocument();
4040
expect(screen.getByText(onlineClusterPayload.name)).toBeInTheDocument();
4141
expect(screen.getByText(offlineClusterPayload.name)).toBeInTheDocument();

frontend/src/components/Topics/New/__test__/New.spec.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,24 +42,24 @@ describe('New', () => {
4242
}));
4343
});
4444
it('checks header for create new', async () => {
45-
await act(() => {
45+
await act(async () => {
4646
renderComponent(clusterTopicNewPath(clusterName));
4747
});
48-
expect(screen.getByRole('heading', { name: 'Create' })).toBeInTheDocument();
48+
expect(screen.getByRole('heading', { name: /local \/ Topics \/ Create/ })).toBeInTheDocument();
4949
});
5050

5151
it('checks header for copy', async () => {
52-
await act(() => {
52+
await act(async () => {
5353
renderComponent(`${clusterTopicCopyPath(clusterName)}?name=test`);
5454
});
55-
expect(screen.getByRole('heading', { name: 'Copy' })).toBeInTheDocument();
55+
expect(screen.getByRole('heading', { name: /local \/ Topics \/ Copy/ })).toBeInTheDocument();
5656
});
5757
it('validates form', async () => {
5858
renderComponent(clusterTopicNewPath(clusterName));
5959
await userEvent.type(screen.getByPlaceholderText('Topic Name'), topicName);
6060
await userEvent.clear(screen.getByPlaceholderText('Topic Name'));
6161
await userEvent.tab();
62-
await expect(
62+
expect(
6363
screen.getByText('Topic Name is required')
6464
).toBeInTheDocument();
6565
await userEvent.type(
@@ -68,7 +68,7 @@ describe('New', () => {
6868
);
6969
await userEvent.clear(screen.getByLabelText('Number of Partitions *'));
7070
await userEvent.tab();
71-
await expect(
71+
expect(
7272
screen.getByText('Number of Partitions is required and must be a number')
7373
).toBeInTheDocument();
7474

0 commit comments

Comments
 (0)