Skip to content

Commit c65eab3

Browse files
committed
add some fixes
1 parent a95d40d commit c65eab3

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

.github/workflows/docker_build.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ jobs:
4444
restore-keys: |
4545
${{ runner.os }}-buildx-
4646
47+
# Build multi platform images and loading them at the same time is not possible with default container runtime : https://github.com/docker/buildx/issues/59
48+
# So let's use containerd instead as it supports this option
49+
# Also containerd is one of the option to allow preserving provenance attestations :https://docs.docker.com/build/attestations/#creating-attestations
4750
- name: Setup docker with containerd
4851
uses: crazy-max/ghaction-setup-docker@v3
4952
with:

.github/workflows/main.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ permissions:
99
contents: read
1010

1111
jobs:
12-
jar-jar-build:
12+
jar-build:
1313
runs-on: ubuntu-latest
1414

1515
permissions:
@@ -22,7 +22,7 @@ jobs:
2222
- name: Checkout
2323
uses: actions/checkout@v4
2424
with:
25-
ref: ${{ github.sha }}
25+
ref: ${{ github.event.pull_request.head.sha }}
2626
token: ${{ github.token }}
2727

2828
- name: Set up JDK
@@ -40,8 +40,6 @@ jobs:
4040
export VERSION=$(./mvnw -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec)
4141
echo "version=${VERSION}" >> $GITHUB_OUTPUT
4242
43-
- name: Upload jar
44-
uses: actions/upload-artifact@v4
4543
- name: Upload jar
4644
uses: actions/upload-artifact@v4
4745
with:

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- uses: actions/checkout@v4
2020
with:
2121
fetch-depth: 0
22-
ref: ${{ github.sha }}
22+
ref: ${{ github.event.pull_request.head.sha }}
2323
token: ${{ github.token }}
2424

2525
- run: |
@@ -68,7 +68,7 @@ jobs:
6868
needs: [release, docker-build]
6969
permissions:
7070
packages: write
71-
id-token: write
71+
id-token: write # Required to authenticate with OIDC for AWS
7272
uses: ./.github/workflows/docker_publish.yml
7373
secrets: inherit
7474
with:

0 commit comments

Comments
 (0)