Skip to content

Commit ddc7058

Browse files
committed
Fix failed acl tests
1 parent 1fd3fad commit ddc7058

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

api/src/test/java/io/kafbat/ui/service/acl/AclsServiceTest.java

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ void createsConsumerDependantAcls() {
103103
.topics(List.of("t1", "t2"))
104104
).block();
105105

106-
//Read, Describe on topics, Read on consumerGroups
106+
//Read, Describe on topics and consumerGroups
107107
Collection<AclBinding> createdBindings = createdCaptor.getValue();
108108
assertThat(createdBindings)
109-
.hasSize(6)
109+
.hasSize(8)
110110
.contains(new AclBinding(
111111
new ResourcePattern(ResourceType.TOPIC, "t1", PatternType.LITERAL),
112112
new AccessControlEntry(principal, host, AclOperation.READ, AclPermissionType.ALLOW)))
@@ -122,9 +122,15 @@ void createsConsumerDependantAcls() {
122122
.contains(new AclBinding(
123123
new ResourcePattern(ResourceType.GROUP, "cg1", PatternType.LITERAL),
124124
new AccessControlEntry(principal, host, AclOperation.READ, AclPermissionType.ALLOW)))
125+
.contains(new AclBinding(
126+
new ResourcePattern(ResourceType.GROUP, "cg1", PatternType.LITERAL),
127+
new AccessControlEntry(principal, host, AclOperation.DESCRIBE, AclPermissionType.ALLOW)))
128+
.contains(new AclBinding(
129+
new ResourcePattern(ResourceType.GROUP, "cg2", PatternType.LITERAL),
130+
new AccessControlEntry(principal, host, AclOperation.READ, AclPermissionType.ALLOW)))
125131
.contains(new AclBinding(
126132
new ResourcePattern(ResourceType.GROUP, "cg2", PatternType.LITERAL),
127-
new AccessControlEntry(principal, host, AclOperation.READ, AclPermissionType.ALLOW)));
133+
new AccessControlEntry(principal, host, AclOperation.DESCRIBE, AclPermissionType.ALLOW)));
128134
}
129135

130136
@Test
@@ -145,10 +151,10 @@ void createsConsumerDependantAclsWhenTopicsAndGroupsSpecifiedByPrefix() {
145151
.topicsPrefix("topicPref")
146152
).block();
147153

148-
//Read, Describe on topics, Read on consumerGroups
154+
//Read, Describe on topics and consumerGroups
149155
Collection<AclBinding> createdBindings = createdCaptor.getValue();
150156
assertThat(createdBindings)
151-
.hasSize(3)
157+
.hasSize(4)
152158
.contains(new AclBinding(
153159
new ResourcePattern(ResourceType.TOPIC, "topicPref", PatternType.PREFIXED),
154160
new AccessControlEntry(principal, host, AclOperation.READ, AclPermissionType.ALLOW)))
@@ -157,7 +163,10 @@ void createsConsumerDependantAclsWhenTopicsAndGroupsSpecifiedByPrefix() {
157163
new AccessControlEntry(principal, host, AclOperation.DESCRIBE, AclPermissionType.ALLOW)))
158164
.contains(new AclBinding(
159165
new ResourcePattern(ResourceType.GROUP, "cgPref", PatternType.PREFIXED),
160-
new AccessControlEntry(principal, host, AclOperation.READ, AclPermissionType.ALLOW)));
166+
new AccessControlEntry(principal, host, AclOperation.READ, AclPermissionType.ALLOW)))
167+
.contains(new AclBinding(
168+
new ResourcePattern(ResourceType.GROUP, "cgPref", PatternType.PREFIXED),
169+
new AccessControlEntry(principal, host, AclOperation.DESCRIBE, AclPermissionType.ALLOW)));
161170
}
162171

163172
@Test

0 commit comments

Comments
 (0)