Skip to content

Commit ed3f758

Browse files
committed
fixes after review
1 parent 01e23a0 commit ed3f758

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

frontend/src/components/Nav/ClusterMenu/ClusterMenu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ interface ClusterMenuProps {
2020
name: Cluster['name'];
2121
status: Cluster['status'];
2222
features: Cluster['features'];
23-
openTab?: string | false;
23+
openTab: string | undefined;
2424
onTabClick: (tabName: string) => void;
2525
}
2626

frontend/src/components/Nav/Nav.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,9 @@ import MenuItem from './Menu/MenuItem';
66
import ClusterMenu from './ClusterMenu/ClusterMenu';
77

88
const Nav: FC = () => {
9-
const [openTab, setOpenTab] = useState<string | false>(false);
9+
const [openTab, setOpenTab] = useState<string>();
1010
const { isSuccess, data: clusters } = useClusters();
1111

12-
const handleTabChange = (tabName: string) => {
13-
setOpenTab((prev) => (prev === tabName ? false : tabName));
14-
};
15-
1612
return (
1713
<aside aria-label="Sidebar Menu">
1814
<S.List>
@@ -26,7 +22,7 @@ const Nav: FC = () => {
2622
status={cluster.status}
2723
features={cluster.features}
2824
openTab={openTab}
29-
onTabClick={() => handleTabChange(cluster.name)}
25+
onTabClick={() => setOpenTab(cluster.name)}
3026
/>
3127
))}
3228
</aside>

0 commit comments

Comments
 (0)