Skip to content

Conversation

@farhadsalehi95
Copy link

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make?

Added comprehensive configuration validation with health check integration. The implementation includes:

  • ConfigValidationHealthIndicator: A reactive health indicator that validates application configuration and reports health status via /actuator/health endpoint
  • ConfigValidator: A component that performs configuration validation on application startup
  • Failure-fast validation: Strict type checking and validation of all configuration sections (auth, kafka, rbac) with clear error messages
  • No breaking changes: Maintains backward compatibility while adding validation capabilities

Is there anything you'd like reviewers to focus on?

  • The reactive health indicator pattern implementation
  • Failure-fast validation semantics without using reflection
  • Proper separation of concerns between health checking and validation logic
  • Use of existing Spring Boot mechanisms instead of direct file parsing

How Has This Been Tested?

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

🦊 (A fox carefully checking configuration files!)

@farhadsalehi95 farhadsalehi95 requested a review from a team as a code owner August 25, 2025 10:51
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Aug 25, 2025
@Haarolean
Copy link
Member

I see most of the points from my previous review haven’t been addressed:

  • blocking calls are still present
  • config handling is incomplete — dynamicConfigOperations works with one file, but users can configure many via spring properties
  • no tests

As i mentioned before, please start with an issue/proposal describing what you want to achieve, so we can discuss approach before code. Right now this patch looks like generated boilerplate rather than something that understands our internals or business logic (e.g. making rbac/auth/clusters mandatory when they are not).

@Haarolean Haarolean closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants