Skip to content

BE: Handle Flux response bodies in MCP tool call results #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

BE: Handle Flux response bodies in MCP tool call results #1491

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
054e524
BE: Handle Flux response bodies in MCP tool call results
elvis-cai Nov 12, 2025
08ee527
Refactor Flux response body handling in McpSpecificationGenerator
elvis-cai Nov 13, 2025
7c6d91a
Merge branch 'main' into feat/be-handle-flux-response-mcp
elvis-cai Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion api/src/main/java/io/kafbat/ui/service/mcp/McpSpecificationGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,12 @@ private Mono<CallToolResult> toCallResult(Object result) {
private Mono<CallToolResult> reponseToCallResult(ResponseEntity<?> response) {
HttpStatusCode statusCode = response.getStatusCode();
if (statusCode.is2xxSuccessful() || statusCode.is1xxInformational()) {
return Mono.just(this.callToolResult(response.getBody()));
Object body = response.getBody();
// Handle Flux response bodies by collecting them into a list
if (body instanceof Flux<?> flux) {
Copy link
Member

@germanosin germanosin Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to see this trick in the callToolResult method

Copy link
Author

@elvis-cai elvis-cai Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick review, good point, updated

return flux.collectList().map(this::callToolResult);
}
return Mono.just(this.callToolResult(body));
} else {
try {
return Mono.just(toErrorResult(objectMapper.writeValueAsString(response.getBody())));
Expand Down
Loading