Skip to content

Conversation

@yeikel
Copy link
Collaborator

@yeikel yeikel commented Dec 12, 2024

What changes did you make? (Give an overview)

Closes #706

Note to reviewers:

Please enable dependency Graph from the repository settings before merging this change

See: https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-the-dependency-graph#supported-package-ecosystems

image

Be aware that enabling dependency graph may lead to additional dependabot security updates

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Manually (please, describe, if necessary)

Tested here : https://github.com/yeikel/kafka-ui/actions/runs/12300201924/job/34327794938

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)

cutest-dog-breeds-jpg

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 12, 2024
@yeikel yeikel force-pushed the maven-dependency-submission-action branch from 7bf4c16 to bae897a Compare December 12, 2024 15:54
@yeikel yeikel marked this pull request as ready for review December 12, 2024 15:55
@yeikel yeikel requested a review from a team as a code owner December 12, 2024 15:55
@yeikel yeikel marked this pull request as draft December 12, 2024 15:55
@yeikel yeikel changed the title Chore: CI: Publish dependency analysis BE: CI: Publish dependency analysis Dec 12, 2024
@yeikel yeikel force-pushed the maven-dependency-submission-action branch from bae897a to c8ebdc8 Compare December 12, 2024 16:00
@yeikel yeikel marked this pull request as ready for review December 12, 2024 16:06
@yeikel yeikel changed the title BE: CI: Publish dependency analysis BE: Chore : Publish dependency analysis Dec 12, 2024
@Haarolean
Copy link
Member

@yeikel do you think we'd need this given we can enable automatic submission?

@yeikel
Copy link
Collaborator Author

yeikel commented Dec 13, 2024

@yeikel do you think we'd need this given we can enable automatic submission?

The docs suggests that it would do the same as this action as it uses this action underneath to submit the dependency graph

I asked here for clarification

I'll mark the PR as a draft for now

@yeikel yeikel marked this pull request as draft December 13, 2024 01:29
@yeikel
Copy link
Collaborator Author

yeikel commented Dec 13, 2024

@yeikel do you think we'd need this given we can enable automatic submission?

The docs suggests that it would do the same as this action as it uses this action underneath to submit the dependency graph

I asked here for clarification

I'll mark the PR as a draft for now

@Haarolean Based on the latest update to my issue above, it seems that this is not needed after all

Could you please enable automatic submission from the repository settings?

@yeikel yeikel closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish dependency analysis

2 participants