Skip to content

Conversation

@wernerdv
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Close #795

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner January 21, 2025 20:00
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 21, 2025
@wernerdv
Copy link
Contributor Author

@Haarolean I added user: "0:0" by analogy with 0ad8695#diff-c855340ec8f8633c4154c7f4f4409f8961a5e9a86cf62bd7da68f195042f7e90R36.
But without that line - also works as expected.
Can you tell me if we really need this?

@Haarolean
Copy link
Member

@Haarolean I added user: "0:0" by analogy with 0ad8695#diff-c855340ec8f8633c4154c7f4f4409f8961a5e9a86cf62bd7da68f195042f7e90R36. But without that line - also works as expected. Can you tell me if we really need this?

It might've been an issue with the now defunct update_run.sh. I might've updated the image, then ran it and got an error related to update_run.sh permissions which I perhaps tried to fix. I suggest to nuke this line from every compose and I'll try this on my machine just in case

remove `user: "0:0"` from compose files
@wernerdv wernerdv requested a review from a team as a code owner January 23, 2025 14:23
@wernerdv
Copy link
Contributor Author

wernerdv commented Jan 23, 2025

@Haarolean

I suggest to nuke this line from every compose

Done

@Haarolean
Copy link
Member

Yeah seems to be working for me without 0:0 now

@Haarolean Haarolean added type/chore Boring stuff, could be refactoring or tech debt impact/documentation A PR with changes which should be addressed in the documentation and removed status/triage/manual Manual triage in progress labels Feb 3, 2025
@Haarolean Haarolean changed the title Fix broken yaml configs for docker compose Docs: Fix broken composes Feb 3, 2025
@Haarolean Haarolean merged commit 5a40117 into kafbat:main Feb 3, 2025
6 checks passed
@Haarolean
Copy link
Member

@wernerdv thank you for this PR!

@wernerdv wernerdv deleted the issues/795 branch February 3, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/documentation A PR with changes which should be addressed in the documentation status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken yaml configs for docker compose

2 participants