use decorator to logging

Signed-off-by: mozillazg <[email protected]>

Author: mozillazg

python/packages/kagent-adk/src/kagent/adk/_session_service.py

@@ -1,3 +1,4 @@
+import functools
 import logging
 from typing import Any, Optional
 
@@ -14,6 +15,17 @@
 logger = logging.getLogger("kagent." + __name__)
 
 
+def logging_http_exception(func):
+    @functools.wraps(func)
+    def wrapper(*args, **kwargs):
+        try:
+            return func(*args, **kwargs)
+        except httpx.HTTPError as exc:
+            logger.error(f"got http exception when {exc.request.method} {exc.request.url}: {exc}")
+            raise
+    return wrapper
+
+
 class KAgentSessionService(BaseSessionService):
     """A session service implementation that uses the Kagent API.
     This service integrates with the Kagent server to manage session state
@@ -25,6 +37,7 @@ def __init__(self, client: httpx.AsyncClient):
         self.client = client
 
     @override
+    @logging_http_exception
     async def create_session(
         self,
         *,
@@ -49,11 +62,7 @@ async def create_session(
             json=request_data,
             headers={"X-User-ID": user_id},
         )
-        try:
-            response.raise_for_status()
-        except httpx.HTTPStatusError:
-            logger.error(f"Failed to create session: {response.text}")
-            raise
+        response.raise_for_status()
 
         data = response.json()
         if not data.get("data"):
@@ -65,6 +74,7 @@ async def create_session(
         return Session(id=session_data["id"], user_id=session_data["user_id"], state=state or {}, app_name=app_name)
 
     @override
+    @logging_http_exception
     async def get_session(
         self,
         *,
@@ -127,18 +137,14 @@ async def get_session(
         except httpx.HTTPStatusError as e:
             if e.response.status_code == 404:
                 return None
-            logger.error(f"Failed to get session: {response.text}")
             raise
 
     @override
+    @logging_http_exception
     async def list_sessions(self, *, app_name: str, user_id: str) -> ListSessionsResponse:
         # Make API call to list sessions
         response = await self.client.get(f"/api/sessions?user_id={user_id}", headers={"X-User-ID": user_id})
-        try:
-            response.raise_for_status()
-        except httpx.HTTPStatusError:
-            logger.error(f"Failed to list sessions: {response.text}")
-            raise
+        response.raise_for_status()
 
         data = response.json()
         sessions_data = data.get("data", [])
@@ -155,19 +161,17 @@ def list_sessions_sync(self, *, app_name: str, user_id: str) -> ListSessionsResp
         raise NotImplementedError("not supported. use async")
 
     @override
+    @logging_http_exception
     async def delete_session(self, *, app_name: str, user_id: str, session_id: str) -> None:
         # Make API call to delete session
         response = await self.client.delete(
             f"/api/sessions/{session_id}?user_id={user_id}",
             headers={"X-User-ID": user_id},
         )
-        try:
-            response.raise_for_status()
-        except httpx.HTTPStatusError:
-            logger.error(f"Failed to delete session: {response.text}")
-            raise
+        response.raise_for_status()
 
     @override
+    @logging_http_exception
     async def append_event(self, session: Session, event: Event) -> Event:
         # Convert ADK Event to JSON format
         event_data = {
@@ -181,11 +185,7 @@ async def append_event(self, session: Session, event: Event) -> Event:
             json=event_data,
             headers={"X-User-ID": session.user_id},
         )
-        try:
-            response.raise_for_status()
-        except httpx.HTTPStatusError:
-            logger.error(f"Failed to append event: {response.text}")
-            raise
+        response.raise_for_status()
 
         # TODO: potentially pull and update the session from the server
         # Update the in-memory session.