Skip to content

Commit 9fde464

Browse files
committed
Update ISBN verifier
This updates the exercise with new test cases from exercism/problem-specifications#2604 and exercism/problem-specifications#2601.
1 parent 84ee767 commit 9fde464

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

exercises/practice/isbn-verifier/.meta/tests.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@ description = "invalid character in isbn is not treated as zero"
3030
[28025280-2c39-4092-9719-f3234b89c627]
3131
description = "X is only valid as a check digit"
3232

33+
[8005b57f-f194-44ee-88d2-a77ac4142591]
34+
description = "only one check digit is allowed"
35+
36+
[fdb14c99-4cf8-43c5-b06d-eb1638eff343]
37+
description = "X is not substituted by the value 10"
38+
3339
[f6294e61-7e79-46b3-977b-f48789a4945b]
3440
description = "valid isbn without separating dashes"
3541

exercises/practice/isbn-verifier/src/test/java/IsbnVerifierTest.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,20 @@ public void xIsOnlyValidAsACheckDigit() {
6868
assertThat(isbnVerifier.isValid("3-598-2X507-9")).isFalse();
6969
}
7070

71+
@Disabled("Remove to run test")
72+
@Test
73+
@DisplayName("only one check digit is allowed")
74+
public void onlyOneCheckDigitIsAllowed() {
75+
assertThat(isbnVerifier.isValid("3-598-21508-96")).isFalse();
76+
}
77+
78+
@Disabled("Remove to run test")
79+
@Test
80+
@DisplayName("X is not substituted by the value 10")
81+
public void xIsNotSubstitutedByTheValue10() {
82+
assertThat(isbnVerifier.isValid("3-598-2X507-5")).isFalse();
83+
}
84+
7185
@Disabled("Remove to run test")
7286
@Test
7387
@DisplayName("valid isbn without separating dashes")

0 commit comments

Comments
 (0)