Skip to content

Commit 00caf5d

Browse files
leizleizcopybara-github
authored andcommitted
Remove includes of callback_forward.h from .cc files
Generally, .cc files should not be forward declaring base::OnceCallback and related classes. If they are using Callbacks, they should include callback.h instead. So treat the base/functional/callback_forward.h includes as superfluous and remove them. Bug: 40318405 Change-Id: I487c907e520d03be3db5b03a8757c7f2559c8278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7201005 Commit-Queue: Lei Zhang <[email protected]> Owners-Override: Kyle Charbonneau <[email protected]> Reviewed-by: Kyle Charbonneau <[email protected]> Cr-Commit-Position: refs/heads/main@{#1550173} NOKEYCHECK=True GitOrigin-RevId: 16723c112a9691d3819d7117e2faf2aeecf1891a
1 parent 0f2d16a commit 00caf5d

File tree

7 files changed

+0
-7
lines changed

7 files changed

+0
-7
lines changed

fuchsia/system_product_info_unittest.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include "base/fuchsia/system_info.h"
1616
#include "base/fuchsia/test_component_context_for_process.h"
1717
#include "base/functional/bind.h"
18-
#include "base/functional/callback_forward.h"
1918
#include "base/location.h"
2019
#include "base/run_loop.h"
2120
#include "base/test/bind.h"

task/sequence_manager/sequence_manager_impl_unittest.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include "base/debug/stack_trace.h"
2020
#include "base/functional/bind.h"
2121
#include "base/functional/callback.h"
22-
#include "base/functional/callback_forward.h"
2322
#include "base/functional/callback_helpers.h"
2423
#include "base/location.h"
2524
#include "base/memory/raw_ptr.h"

test/rectify_callback_unittest.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
#include "base/functional/bind.h"
1111
#include "base/functional/callback.h"
12-
#include "base/functional/callback_forward.h"
1312
#include "base/functional/callback_helpers.h"
1413
#include "base/test/bind.h"
1514
#include "testing/gtest/include/gtest/gtest.h"

test/run_until_unittest.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
#include "base/test/run_until.h"
66

7-
#include "base/functional/callback_forward.h"
87
#include "base/functional/callback_helpers.h"
98
#include "base/synchronization/atomic_flag.h"
109
#include "base/task/bind_post_task.h"

test/task_environment.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include "base/check.h"
1313
#include "base/containers/enum_set.h"
1414
#include "base/debug/stack_trace.h"
15-
#include "base/functional/callback_forward.h"
1615
#include "base/functional/callback_helpers.h"
1716
#include "base/lazy_instance.h"
1817
#include "base/location.h"

test/task_environment_unittest.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include "base/check.h"
1414
#include "base/debug/debugger.h"
1515
#include "base/functional/bind.h"
16-
#include "base/functional/callback_forward.h"
1716
#include "base/functional/callback_helpers.h"
1817
#include "base/logging.h"
1918
#include "base/run_loop.h"

threading/platform_thread_metrics.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
#include "base/check.h"
1212
#include "base/functional/bind.h"
13-
#include "base/functional/callback_forward.h"
1413
#include "base/memory/ptr_util.h"
1514
#include "base/metrics/histogram_base.h"
1615
#include "base/metrics/sparse_histogram.h"

0 commit comments

Comments
 (0)