Fix LoggingTest.CheckContainingFunc

An upcoming LLVM change
(llvm/llvm-project#107114) causes the optimizer
to remove the checks for the value of the death_location variable since
all calls to CheckContainingFunc(...) pass one of the 3 checked values.
To avoid this, we add [[clang:optnone]] to the function to prevent this
optimization.

Bug: 369900509
Fixed: 369900509
Change-Id: I502f1dd301590b8673f000b3067327813628ae3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905531
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1363470}
NOKEYCHECK=True
GitOrigin-RevId: 2343bacd0698a54f1b58b633874cb65d6c725404

Author: alanzhao1

logging_unittest.cc

@@ -374,7 +374,8 @@ TEST_F(LoggingTest, DuplicateLogFile) {
 #endif  // BUILDFLAG(IS_CHROMEOS_ASH)
 
 #if !CHECK_WILL_STREAM() && BUILDFLAG(IS_WIN)
-NOINLINE void CheckContainingFunc(int death_location) {
+// Tell clang to not optimize this function or else it will remove the CHECKs.
+[[clang::optnone]] NOINLINE void CheckContainingFunc(int death_location) {
   CHECK(death_location != 1);
   CHECK(death_location != 2);
   CHECK(death_location != 3);