Automated fixes for Error Prone warning: FieldCanBeFinal, FieldCanBeLocal, FieldCanBeStatic (part 5)

AX-Relnotes: n/a.
Bug: 40661145
Change-Id: Ic40a406086c87729554a9d7e7df6b5cb9dd1f9f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6531367
Commit-Queue: Andrew Grieve <[email protected]>
Owners-Override: Andrew Grieve <[email protected]>
Reviewed-by: Henrique Nakashima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1458335}
NOKEYCHECK=True
GitOrigin-RevId: 6d903dddebf88f24cf9f9ba504777ea4b81f429b

Author: agrieve

android/java/src/org/chromium/base/ApplicationStatus.java

@@ -52,7 +52,7 @@ public class ApplicationStatus {
 
     private static class ActivityInfo {
         private int mStatus = ActivityState.DESTROYED;
-        private ObserverList<ActivityStateListener> mListeners = new ObserverList<>();
+        private final ObserverList<ActivityStateListener> mListeners = new ObserverList<>();
 
         /**
          * @return The current {@link ActivityState} of the activity.

android/java/src/org/chromium/base/DeviceInfo.java

@@ -37,7 +37,7 @@ public final class DeviceInfo {
     private static boolean sInitialized;
 
     /** The versionCode of Play Services. Can be overridden in tests. */
-    private String mGmsVersionCode;
+    private final String mGmsVersionCode;
 
     /** Whether we're running on Android TV or not */
     private final boolean mIsTv;

android/java/src/org/chromium/base/LifetimeAssert.java

@@ -77,8 +77,8 @@ public WrappedReference(
             sActiveWrappers.add(this);
         }
 
-        private static ReferenceQueue<Object> sReferenceQueue = new ReferenceQueue<>();
-        private static Set<WrappedReference> sActiveWrappers =
+        private static final ReferenceQueue<Object> sReferenceQueue = new ReferenceQueue<>();
+        private static final Set<WrappedReference> sActiveWrappers =
                 Collections.synchronizedSet(new HashSet<>());
 
         static {

android/java/src/org/chromium/base/TraceEvent.java

@@ -773,13 +773,13 @@ public ViewInfo(
             mRes = res;
         }
 
-        private int mId;
-        private int mParentId;
-        private boolean mIsShown;
-        private boolean mIsDirty;
-        private String mClassName;
+        private final int mId;
+        private final int mParentId;
+        private final boolean mIsShown;
+        private final boolean mIsDirty;
+        private final String mClassName;
         // One can use mRes to resolve mId to a resource name.
-        private android.content.res.Resources mRes;
+        private final android.content.res.Resources mRes;
     }
 
     /**

android/java/src/org/chromium/base/jank_tracker/FrameMetricsListener.java

@@ -49,10 +49,10 @@ public void onDisplayChanged(int sdkDisplayId) {
         }
     }
 
-    private DisplayListenerBackend mBackend = new DisplayListenerBackend();
+    private final DisplayListenerBackend mBackend = new DisplayListenerBackend();
 
     private final FrameMetricsStore mFrameMetricsStore;
-    private AtomicBoolean mIsRecording = new AtomicBoolean(false);
+    private final AtomicBoolean mIsRecording = new AtomicBoolean(false);
     // Microseconds between each frame.
     private long mVsyncInterval;
 

android/java/src/org/chromium/base/jank_tracker/JankActivityTracker.java

@@ -29,7 +29,7 @@ class JankActivityTracker extends JankTrackerStateController implements Activity
     private final ThreadChecker mThreadChecker = new ThreadChecker();
     private final DestroyChecker mDestroyChecker = new DestroyChecker();
 
-    private WeakReference<Activity> mActivityReference;
+    private final WeakReference<Activity> mActivityReference;
 
     JankActivityTracker(
             Activity context,

android/java/src/org/chromium/base/metrics/CachingUmaRecorder.java

@@ -223,7 +223,7 @@ void flushTo(UmaRecorder recorder) {
      * <p>
      * Using {@link AtomicInteger} because the value may need to be updated with a read lock held.
      */
-    private AtomicInteger mDroppedHistogramSampleCount = new AtomicInteger();
+    private final AtomicInteger mDroppedHistogramSampleCount = new AtomicInteger();
 
     /** Cache of user actions. */
     @GuardedBy("mRwLock")

android/java/src/org/chromium/base/process_launcher/ChildProcessConnection.java

@@ -192,7 +192,7 @@ private static boolean useBackgroundNotPerceptibleBinding() {
 
     private final Handler mLauncherHandler;
     private final Executor mLauncherExecutor;
-    private ComponentName mServiceName;
+    private final ComponentName mServiceName;
     private final @Nullable ComponentName mFallbackServiceName;
     private @Nullable Intent mBindIntent;
 

android/java/src/org/chromium/base/task/AsyncTask.java

@@ -69,7 +69,7 @@ public abstract class AsyncTask<Result extends @Nullable Object> {
 
     private final AtomicBoolean mCancelled = new AtomicBoolean();
     private final AtomicBoolean mTaskInvoked = new AtomicBoolean();
-    private int mIterationIdForTesting = PostTask.sTestIterationForTesting;
+    private final int mIterationIdForTesting = PostTask.sTestIterationForTesting;
 
     private static class StealRunnableHandler implements RejectedExecutionHandler {
         @Override

android/java/src/org/chromium/base/task/ChainedTasks.java

@@ -33,7 +33,7 @@ public class ChainedTasks {
     private boolean mFinalized;
 
     private volatile boolean mCanceled;
-    private int mIterationIdForTesting = PostTask.sTestIterationForTesting;
+    private final int mIterationIdForTesting = PostTask.sTestIterationForTesting;
 
     private final Runnable mRunAndPost =
             new Runnable() {